2011-11-16 Bill Erickson * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0651.schema.unnest-hold-permit-upgrade- script-repair.sql: Repair errant explode_array in upgrade script. The upgrade script 0562.schema.copy_active_date.sql included 2 calls to explode_array after explode_array had been removed from the baseline schema. This upgrade just copies the contents of the action.hold_request_permit_test function from the baseline schema to repair the function for anyone following the upgrade scripts. Signed-off-by: Bill Erickson 2011-11-16 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0650.function.copy_visibility_vs_peer_b ibs.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.temp.sql: Stamping upgrade script for copy visibility vs peer-bibs fix Signed-off-by: Mike Rylander 2011-10-24 Thomas Berezansky * Open-ILS/src/sql/Pg/999.functions.global.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.temp.sql: Distinct cache_copy_visibility copy/record Because if you peer bib a copy to the bib it is on things don't like you. Signed-off-by: Thomas Berezansky Signed-off-by: Mike Rylander 2011-10-18 Thomas Berezansky * Open-ILS/src/perlmods/lib/OpenILS/SIP.pm: Obey renewal rules for SIP2 Checkout If local policy OR the selfcheck are set to not do renewals than don't attempt them. Also, return whether a renewal was attempted (success or failure) so that the self check on the other end has a better clue what went on. Signed-off-by: Thomas Berezansky Signed-off-by: Mike Rylander 2011-09-26 Lebbeous Fogle-Weekley * Open-ILS/examples/opensrf.xml.example, Open-ILS/src/asterisk/pbx-daemon/eg-pbx-allocator.pl, Open-ILS/src/asterisk/pbx-daemon/eg-pbx-daemon.conf, Open-ILS/src/perlmods/lib/OpenILS/Application/JustInTime.pm, Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger.pm, Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Event.pm, Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/EventGroup.pm: Improvement for telephony: just-in-time event revalidation One of the shortcomings with using the Action/Trigger based telephony in Evergreen until now was that while you might have overdue notices generated and sent to a system where Asterisk runs for later calling, but if the notice was generated on a Saturday night, and you have Asterisk set up not to place any calls again until Monday morning, Asterisk has no way of revalidating that call at the last minute. That is, the system could not determine whether the items that were overdue on Saturday night are still overdue on Monday morning, and whether the call should still be made. Now we have a workable solution to that. The eg-pbx-allocator.pl script, which takes call files for Asterisk from a "staging" directory and slowly drips them onto Asterisk's spool can now consult an open-ils.justintime which in turn asks open-ils.trigger whether given events, enumerated within the call files themselves, are still valid. open-ils.trigger is designed to run as a private service, so that's why we need a public service that doesn't do anything too sensitive. This open-ils.justintime service can potentially be extended to offer other just-in-time information to the allocator right before a call goes onto Asterisk's spool. For example, that might be a good time to check the time of day and make a late decision on which phone number to use for a given user (day_phone, evening_phone, other_phone). Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Mike Rylander 2011-11-15 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0649.schema.fix_full_circ_count_view.sq l, Open-ILS/src/sql/Pg/upgrade/XXXX.schema.fix_full_circ_count_view.sq l: Stamped upgrade for full circ count view fix Signed-off-by: Mike Rylander 2011-09-29 Thomas Berezansky * Open-ILS/src/sql/Pg/extend-reporter.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.schema.fix_full_circ_count_view.sq l: Use DISTINCT in counts to avoid dupes Otherwise you get: Legacy count + 2(normal count)(aged count) Signed-off-by: Thomas Berezansky Signed-off-by: Mike Rylander 2011-09-29 Dan Wells * Open-ILS/src/sql/Pg/extend-reporter.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.schema.fix_full_circ_count_view.sq l: Full Circ Count View Amplifies Legacy Circs The current extend_reported.full_circ_count sums the legacy circ count column, but this results in amplifying the count by the number of current circs in the system. This commit adds the legacy count to the GROUP BY instead of summing it. Signed-off-by: Dan Wells Signed-off-by: Mike Rylander 2011-11-15 Thomas Berezansky * Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm: Skip shelved holds at checkout auto-fill Already happened for volume/title hold, but target map checking wasn't checking to see if the current copy was shelved. Signed-off-by: Thomas Berezansky Signed-off-by: Mike Rylander 2011-10-16 Dan Scott * Open-ILS/src/extras/Makefile.install: Net::Z3950::SimpleServer 1.15 should not require sedding Checking both versions of the packages listed on ftp.indexdata.dk, the hardcoded path to yaz-config does not exist in Makefile.PL - thus, we should be able to drop the "sed" instruction for 1.15. Signed-off-by: Dan Scott Signed-off-by: Mike Rylander 2011-10-16 Dan Scott * Open-ILS/src/extras/Makefile.install: Install yaz-4.2 and Net::Z3950::Simpleserver 1.15 Net::Z3950::Simpleserver 1.14+ requires yaz 4.2.x, as well as currently suffering from a Makefile.PL problem that involves a hard-coded path to yaz-config (https://rt.cpan.org/Public/Bug/Display.html?id=70444). Provide a sed command to resolve the latter problem and upgrade our "current version of yaz" to yaz 4.2.x. Signed-off-by: Dan Scott Signed-off-by: Mike Rylander 2011-09-28 Lebbeous Fogle-Weekley * Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm, Open-ILS/web/opac/extras/circ/alt_holds_print.html, Open-ILS/web/opac/extras/circ/alt_holds_print.js: Fix a problem in the clear holds shelf list printer This is a "special" interface that you get to via Admin -> For Developers -> Local Administration in the staff client. The addition features to one "side" of this hackish interface of label affix and parts had caused breakage on the other "side." This fixes that. Also improve document printing, making it less likely the progress dialog itself gets printed. One day this will be replaced with something better. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Mike Rylander 2011-11-15 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0648.function.merge_record_assets_meets _acq.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.function.merge_record_assets_meets _acq.sql: Stamped upgrade for asset.merge_record_assets fix Signed-off-by: Mike Rylander 2011-09-13 Jason Etheridge * Open-ILS/src/sql/Pg/999.functions.global.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.function.merge_record_assets_meets _acq.sql: LP#849143 fix some gaps in bib record merging Tweaks asset.merge_record_assets such that it considers acquisition line items and user requests, serial subscriptions, booking resource types, biblio monograph parts, and biblio peer bib copy maps. I'm not handling vandelay.queued_record.imported_as or any other vandelay tables, but we may wish to do that too. We're also leaving acq.acq_lineitem_history alone. Signed-off-by: Jason Etheridge Signed-off-by: Mike Rylander 2011-11-01 Liam Whalen * Open-ILS/xul/staff_client/server/cat/marcedit.js: Aligned the MARC editor subfields to 'start' fixes long subfield display When viewing a record in the MARC editor that has extremely long entries in a subfield, the output would align in the center of the subfield making the output hard to read. This patch adds an align: 'start' option to both the subfield, and the subfield code elements in the marcSubfield function to make the subfields align in a more readable manner. Signed-off-by: Liam Whalen Signed-off-by: Mike Rylander 2011-11-15 Mike Rylander * : Merge remote-tracking branch 'eg-working/collab/phasefx/merged_bill_and_receipt_fixes' 2011-09-13 Jason Etheridge * Open-ILS/web/opac/locale/en-US/lang.dtd, Open-ILS/xul/staff_client/server/cat/copy_browser.js, Open-ILS/xul/staff_client/server/cat/copy_browser.xul: LP#848945 - Hide Empty Libs checkbox The "Show Libraries With Items" button in Holdings Maintenance shows all the libs with items regardless of the library/depth filters. One problem is that when the list refreshes (whenever an item/volume is edited, deleted, or added), staff using this feature have to re-press the button, which can take a while for some bibs. This branch removes this button and replaces it with a "sticky" checkbox labelled "Hide Empty Libs". This allows you to do almost the same thing; you can set the context library to Consortium and the depth filter to the lowest depth, which would normally show all libs, but then use the checkbox to prune out the ones that have no children and no volumes(*). One possible use case that we'd lose is the ability to show a specific set of libs that don't already have volumes in addition to all the libs that do. * - Also, the test for whether to hide an org or not is very simplistic, but easy to implement. A more aggressive test would hide a library and all its descendants if none of the descendants have volumes. Signed-off-by: Jason Etheridge Signed-off-by: Mike Rylander 2011-11-15 Mike Rylander * Open-ILS/web/js/ui/default/actor/user/register.js: Patch from Jeff Davis (SITKA) fixing cardless patron updates Quoth the bug report (https://bugs.launchpad.net/evergreen/+bug/851110): On our Evergreen 2.0.8 system, it sometimes arises that a patron's card gets deleted. If it was the patron's only card, it becomes impossible to add a new card to the account via the staff client. How to reproduce: 1. Retrieve a patron record for a patron who has no associated card. 2. Click the Edit button. 3. Click Replace Barcode and enter a new barcode. 4. Click Save. This does not work - the process hangs, and if you hit Reload, you will find that your changes were not saved. I believe this happens because some code in register.js assumes the patron has at least one card. I have a potential fix that this comment box is too small to contain ... uh, that is to say, I will post it momentarily. Which he did, and I applied. Signed-off-by: Mike Rylander 2011-09-22 Thomas Berezansky * Open-ILS/xul/staff_client/chrome/content/util/barcode.js: Throw out non-digit barcodes for strict check Characters like "." are valid for numbers, but not the algorithm. Thus, we need to throw out "16.00" despite the check for "16.00" == Number("16.00") returning true. Signed-off-by: Thomas Berezansky Signed-off-by: Mike Rylander 2011-09-22 Thomas Berezansky * Open-ILS/xul/staff_client/server/circ/copy_status.js: Don't check barcode without strict enabled Item status was, unlike other interfaces, doing the strict check, THEN looking at the checkbox and if it was checked return. This caused issues when the barcode crashes out the strict checking. Signed-off-by: Thomas Berezansky Signed-off-by: Mike Rylander 2011-10-07 Thomas Berezansky * Open-ILS/web/opac/skin/default/js/holds.js: Fix JSPac Hold Editor Org Selector Don't wipe out all changes just because the OU was changed. Signed-off-by: Thomas Berezansky Signed-off-by: Mike Rylander 2011-11-15 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0647.data.hold-notification-cleanup-mod .sql, Open-ILS/src/sql/Pg/upgrade/XXXX.data.hold-notification-cleanup-mod .sql: Stamped upgrade script for hold_notification update via A/T cleanup module Signed-off-by: Mike Rylander 2011-06-09 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Cleanup.pm, Open-ILS/src/sql/Pg/950.data.seed-values.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.data.hold-notification-cleanup-mod .sql: Hold notification creation A/T cleanup module New CreateHoldNotification Action/Trigger cleanup module that, when linked to a hold-based event_definition, adds an entry into action.hold_notification for each hold processed. The main user-facing change from this will be that the hold notification time / count in the staff client will now take A/T notices into effect in addition to manually created hold notifications. Signed-off-by: Bill Erickson Signed-off-by: Mike Rylander 2011-10-18 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/Application/Collections.pm: Further support for "circ.collections.exempt" setting Added support for skipping users that have the "circ.collections.exempt" setting in the API call: open-ils.collections.users_of_interest.warning_penalty.retrieve This call is an alternate entry point for finding users to consider for collections processing Signed-off-by: Bill Erickson Signed-off-by: Mike Rylander 2011-10-19 Steven Callender * Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/act ion.pm: Reshelving update. Update to the reshelving code to make it faster and utilize the new status change time field on asset.copy. Signed-off-by: Steven Callender Signed-off-by: Mike Rylander 2011-11-14 Lebbeous Fogle-Weekley * Open-ILS/src/templates/opac/parts/record/issues.tt2: TPac: Fix glitch in displaying received holdings Under "issues held" on the record detail page, holdings summaries for received issues are nested in an additional layer of array as compared to MFHD-based holdings, so compensate. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Bill Erickson 2011-10-24 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm: Clear shelf canceled holds notification fix After cancelling a batch of holds via the clear-shelf process, before we send the holds off to action/trigger for potential notification generation, re-fetch the holds from the DB to pick up the calculated cancel_time value (i.e. get a real value for "now"). Otherwise, A/T may die attempting to create a DateTime object by parsing "now". Signed-off-by: Bill Erickson Signed-off-by: Mike Rylander 2011-11-02 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm, Open-ILS/src/templates/opac/parts/place_hold.tt2, Open-ILS/src/templates/opac/parts/place_hold_result.tt2, Open-ILS/src/templates/opac/parts/record/issues.tt2, Open-ILS/src/templates/opac/parts/record/summary.tt2, Open-ILS/src/templates/opac/parts/result/table.tt2: TPac; hold success confirmation; redirect repairs 1. After a successful hold placement, provide feedback to the user that the hold placement succeeded. After placement, the user is taken to a page (same page for failed holds) where the title(s) are listed along with the success/failure information for each. 2. In some cases, the user may be redirected to the my account page instead of the point of origin for holds placement. This occurs generally when the user is not already logged in and is asked to log in prior to holds placement. 3. As a side effect, this change replaces one of the ornery history.go(-1) actions with a true href/URL. Signed-off-by: Bill Erickson Signed-off-by: Mike Rylander 2011-11-03 Bill Erickson * Open-ILS/src/templates/opac/parts/record/awards.tt2, Open-ILS/src/templates/opac/parts/result/table.tt2: TPac; reduce vertical space caused by chilifresh link CSS loaded from chilifresh forces a fixed height on the .chili_review class, which causes significant vertical space gobbling in the results and details pages. Solution is to change the chili_review container from a
to a , where the height has no effect. Signed-off-by: Bill Erickson Signed-off-by: Mike Rylander 2011-10-23 Dan Scott * Open-ILS/src/c-apps/Makefile.am, Open-ILS/src/c-apps/idlval.c: Make idlval build, rather than be dead code The tool "idlval" contained in Open-ILS/src/c-apps can be used to check the correctness of fieldmapper definitions in files like Open-ILS/examples/fm_IDL.xml - but currently does not have a build target, nor does it compile cleanly due to the use of unspecified OpenSRF header files. This commit adds a build target, fixes the compile problems, and installs the tool in the bin directory. Signed-off-by: Dan Scott Signed-off-by: Jason Stephenson Signed-off-by: Mike Rylander 2011-11-08 Jason Stephenson * Open-ILS/examples/fm_IDL.xml: Add link to cbs from bre via bre.source -> cbs.id in fm_IDL.xml. Signed-off-by: Jason Stephenson Signed-off-by: Mike Rylander 2011-11-08 Jason Etheridge * Open-ILS/xul/staff_client/server/locale/en-US/patron.properties, Open-ILS/xul/staff_client/server/patron/summary.js, Open-ILS/xul/staff_client/server/patron/summary_overlay.xul, Open-ILS/xul/staff_client/server/patron/summary_overlay_horiz.xul: Show the patron account Create Date in both horizontal and vertical patron summary panes Signed-off-by: Jason Etheridge Signed-off-by: Mike Rylander 2011-11-08 Jason Etheridge * Open-ILS/xul/staff_client/chrome/content/cat/opac.js, Open-ILS/xul/staff_client/server/cat/util.js, Open-ILS/xul/staff_client/server/cat/volume_copy_creator.js: LP887822 mint_condition/Quality not set correctly during item creation. Specifically, the Javascript object for a new item (acp) does not explicitly set the mint_condition field, leaving it null. The item attribute editor treats the null as false (which it displays as "Mediocre" for that field). The database has a not null constraint the corresponding column in asset.copy, and defaults to true. So a new item in the attribute editor will show "Mediocre", but when actually created, will become "Good". This branch just sets mint_condition to true when an item is created. Signed-off-by: Jason Etheridge Signed-off-by: Mike Rylander 2011-11-09 Bill Erickson * Open-ILS/src/templates/opac/password_reset.tt2: Tpac; repair login link after password reset After a successful password reset, the UI offers a link to "Log In to My Account". Loging in this way would ultimately redirect the user back to the password reset form. This patch updates the Log In link to point to myopac/main, which will direct the user to log in first, instead of pointing directly to /login, which, lacking any other information, will return the user to the referer after logging in. Signed-off-by: Bill Erickson Signed-off-by: Mike Rylander 2011-11-15 Mike Rylander * : Merge remote-tracking branch 'eg-working/collab/berick/lp_888239_prevent_post-capture_hold_suspend' 2011-11-11 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm, Open-ILS/src/templates/opac/password_reset.tt2: tpac; honor password reset matching email setting If the "circ.password_reset_request_requires_matching_email" org unit setting is enable, prompt the user to enter the email address associated with the account and subsequently pass it on to the password_reset api call. Signed-off-by: Bill Erickson Signed-off-by: Mike Rylander 2011-11-14 Lebbeous Fogle-Weekley * Open-ILS/web/js/dojo/openils/widget/HoldingCode.js: Serials: in the holding code mini-wizard, offer a dropdown for seasons This spares the user from having to remember the MFHD code for the season, when dealing with periodicals issued by season (21 - 24 for Spring - Winter, respectively). This also applies sets the "scrollOnFocus" attribute to false for the dijits within the mini wizard, as the jumpy behavior you get in less-than-fullscreen staff client windows is otherwise maddening. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Mike Rylander 2011-11-14 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader.pm: tpac; improve ssl and authentication redirection Create a better separation between pages the require SSL and those that also require authentication. This change has a number of beneficial side effects: 1. If a user is already logged in and is somehow redirected to the non-SSL version of a page requiring SSL (via, for example, some external link), they are simply taken to the SSL equivlent of the page first. If they are found to be logged in, we're done. If not, they are directed to the login page like usual. 2. password_reset page now requires SSL (but not auth, obviously) 3. Removed the unnecessary warning about logging out on a non-SSL connection. We now redirect the user to the SSL version of logout so, if they are in fact logged in, they can be successfully logged out. Signed-off-by: Bill Erickson Signed-off-by: Mike Rylander 2011-10-26 Thomas Berezansky * Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm: Make checkin retargeting parts-aware Skip part holds on copies san parts Skip part holds for parts not on the copy Skip title holds for copies with parts Signed-off-by: Thomas Berezansky Signed-off-by: Bill Erickson 2011-10-11 Lebbeous Fogle-Weekley * Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Reactor.pm, Open-ILS/src/support-scripts/edi_pusher.pl: More filtering of characters that could end up in PO JEDI template output Backslashes cause problems too. Let's JSON encode this thing and get it right once and for all. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Ben Shum Signed-off-by: Bill Erickson 2011-11-10 Lebbeous Fogle-Weekley * Open-ILS/web/js/dojo/openils/widget/HoldingCode.js, Open-ILS/web/js/ui/default/serial/subscription/issuance.js: Serials: allow freer input in holding code mini-wizard In the Subscription Details interface of the Alternate Serials Control View, under the Issuance tab, if you create a new issuance you can now enter things like "01/02" in (say) the month field to denote a combined January/February issue. All those fields are now free-form, whereas some of them used to be numeric only. Also, avoid an occasional issue where an error message about dijit.form.DateTextBox not being a constructor would appear in the JavaScript console. The problem was in a race condition among some co-dependent JavaScript files that were all being loaded at the same time. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Dan Wells 2011-11-10 Jason Etheridge * Open-ILS/examples/apache/eg_vhost.conf, Open-ILS/web/opac/common/js/RemoteRequest.js, Open-ILS/xul/staff_client/chrome/content/util/network.js: LP88653 force SSL for requests from local XUL Modifies RemoteRequest.js to convert any http:// request URL to https:// if the requesting location has a chrome:// protocol. Modifies util/network.js such that any use of util.network.request (as opposed to util.network.simple_request) will assume "secure" for the resulting request. Adds an example to the bottom of eg_vhost.conf for forcing SSL for an entire site (OPAC and everything), courtesy of Dan Wells. Signed-off-by: Jason Etheridge Signed-off-by: Dan Wells 2011-11-10 Dan Scott * Open-ILS/src/extras/Makefile.install, README: Fedora 16 updates to README and Makefile.install Fedora 16 is out, we can improve the README and Makefile.install some to better support it. Signed-off-by: Dan Scott 2011-11-09 Bill Erickson * Open-ILS/src/templates/opac/myopac/holds/edit.tt2: TPac; disallow certain actions for captured holds In the hold edit page, where users can update the pickup library, suspend holds, etc. disallow actions that don't make sense for holds that have already been captured. These include suspending the hold and changing the expire time. This patch also replaces the confusing "Cancel" button in the hold edit interface (which does not cancel the hold) with a "Go Back" button which returns to the holds list. Signed-off-by: Bill Erickson 2011-11-09 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm, Open-ILS/src/templates/opac/myopac/holds.tt2: TPac; batch hold update detects suspension of captured hold If the user attempts to suspend a captured hold via batch hold update, warn that user af the update the some holds may not have been suspended and why. Signed-off-by: Bill Erickson 2011-11-09 Bill Erickson * Open-ILS/src/extras/ils_events.xml, Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm: Prevent hold suspencion for captured holds in API This codifies at the API layer the standard Evergreen practice of disallowing suspension of holds that have already been captured. Signed-off-by: Bill Erickson 2011-11-09 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm: prevent suspend in transit initial poking Signed-off-by: Bill Erickson 2011-11-09 Thomas Berezansky * Open-ILS/xul/staff_client/server/cat/marcedit.js: XML.ignoreWhitespace causes syntax errors So remove it. Disabling pretty printing appears to be enough to fix the marc editor. Signed-off-by: Thomas Berezansky Signed-off-by: Jason Etheridge 2011-11-09 Jason Stephenson * Open-ILS/src/perlmods/lib/OpenILS/Utils/Cronscript.pm.in: Fix a typo that snuck through the cracks in Cronscript.pm.in. We had Opensrf::AppSession rather than OpenSRF::AppSession, which isn't caught by the simple use_ok() tests that we largely rely on for our current Perl test suite. In addition, when we manually tested the change to Cronscript.pm.in, we didn't do both configure && make to ensure that the new version of Cronscript.pm reflected the changes. Lots to learn, luckily the method wasn't being used by anything else in Evergreen yet. Signed-off-by: Jason Stephenson Signed-off-by: Dan Scott 2011-11-07 Thomas Berezansky * Open-ILS/xul/staff_client/server/cat/marcedit.js: Fix vanishing whitespace in marc editor XML.ignoreWhitespace and XML.prettyPrinting cause whitespace to vanish. So disable them at the top of marcedit.js. Signed-off-by: Thomas Berezansky Signed-off-by: Jason Etheridge 2011-10-31 Galen Charlton * Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm: lp849447: trival stylistic tweaks - rename variable avoid double-negative - avoid 'Variable declared in conditional statement' perlcritic gripe Signed-off-by: Galen Charlton Signed-off-by: Mike Rylander 2011-11-08 Mike Rylander * Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm, Open-ILS/xul/staff_client/chrome/content/main/constants.js: Protect against slony replication lag, LP#621448 Make open-ils.circ.captured_holds.id_list.* API calls authoritative within the staff client to avoid replication-lag related stale displays. Inspired by James Fournie at SITKA. Signed-off-by: Mike Rylander 2011-11-07 Dan Scott * README: README: Use consistent endings (none!) for titles/subtitles Most, but not all, of the titles/subtitles had colons appended. This looks really weird in the Table of Contents, so try to be consistently unweird and have no appended colons. Signed-off-by: Dan Scott 2011-11-07 Dan Scott * README: Backup the existing opensrf config files before copying Per a suggestion from Wolf Halton , create backup versions of the opensrf configuration files when we're copying the Evergreen example versions over, so that we can retrieve the Jabber user names and passwords and domains from the backups (if necessary). Signed-off-by: Dan Scott 2011-11-03 Bill Erickson * Open-ILS/src/templates/opac/parts/record/body.tt2: TPac; detail page "Search Results" page correction On the detail page, when the user selects the "Search Results" link to return the original search results, return to the correct page in the search. The correct page will be the page where the currently viewed record sits within the search. Normally, this is the last viewed results page. However, if the user does some paging within the detail page, enough to cross a page boundry, "Search Results" will take them to the new page (i.e. the page w/ the current record). Signed-off-by: Bill Erickson Signed-off-by: Lebbeous Fogle-Weekley 2011-11-02 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm: TPac; sort items out list by due date, oldest first Sort items most in need of return (i.e. oldest due date) to top. This is done by replacing the call to "open-ils.actor.user.checked_out", which does a lot more than we need, in a way that does not support sorting/paging, with a simple json_query. Signed-off-by: Bill Erickson Signed-off-by: Lebbeous Fogle-Weekley 2011-09-28 Thomas Berezansky * Open-ILS/xul/staff_client/chrome/content/main/menu.js: Close All Tabs shortcut Enable CTRL+Click on the close tab "X" to close all tabs. Signed-off-by: Thomas Berezansky Signed-off-by: Lebbeous Fogle-Weekley 2011-09-27 Jason Etheridge * Open-ILS/web/opac/skin/default/js/holds.js: LP#860845 hold placement UI can break hold placement UI can break and give misleading error on Submit Adds some defensive coding, but since I don't quite grok everything going on here, may not be the best fix. Signed-off-by: Jason Etheridge Signed-off-by: Lebbeous Fogle-Weekley 2011-09-13 Thomas Berezansky * Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/act ion.pm: Skip forced targeting of frozen holds Otherwise a frozen hold can be manually retargeted by staff and captured. Signed-off-by: Thomas Berezansky Signed-off-by: Lebbeous Fogle-Weekley 2011-09-15 Bill Erickson * Open-ILS/src/templates/acq/common/li_table.tt2, Open-ILS/web/js/ui/default/acq/common/li_table.js: Acq: List provider code in lineitem lists Along with selection list and purchase order, when an item is attached to a purchase order, also show the provider code Signed-off-by: Bill Erickson Signed-off-by: Lebbeous Fogle-Weekley 2011-10-24 Bill Erickson * Open-ILS/src/templates/opac/parts/misc_util.tt2: TPac; improved UPC extraction Handle the case where a record has multiple UPC's. When this occurs, use the first UPC as the value for added content lookups as necessary. Signed-off-by: Bill Erickson Signed-off-by: Lebbeous Fogle-Weekley 2011-11-01 James Fournie * Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/Search.pm: This prevents the acq unified_search method from returning anything other than the objects of the expected type. This is to address LP 884991 in which Acq users get a perm error for each result of a search that they don't have access to retrieve. They shouldn't even know about the existence of anything they don't have access to retrieve. Signed-off-by: James Fournie Signed-off-by: Lebbeous Fogle-Weekley 2011-11-02 Bill Erickson * Open-ILS/src/templates/opac/parts/hold_error_messages.tt2, Open-ILS/src/templates/opac/parts/place_hold_result.tt2: Tpac; hold error message 18n string extraction repairs Make it possible for xgettext.pl (using Locale::Maketext::Extract::Plugin::TT2) to extract hold error message strings for translation. The plugin is not quite smart enough to extract wholly dynamic values from the templates, since it (presumably) only parses the templates and does not execute them. The solution is to wrap the strings in l() where they are defined. Add an example for the EVENT_MSG_MAP for the event PATRON_EXCEEDS_FINES. Signed-off-by: Bill Erickson Signed-off-by: Lebbeous Fogle-Weekley 2011-11-04 Lebbeous Fogle-Weekley * Open-ILS/src/sql/Pg/upgrade/0646.schema.lp854972_copy_counts_unshad ow.sql: Correct oversight: replace old with new approach to upgrade script versioning Signed-off-by: Lebbeous Fogle-Weekley 2011-09-20 James Fournie * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/040.schema.asset.sql, Open-ILS/src/sql/Pg/upgrade/0646.schema.lp854972_copy_counts_unshad ow.sql: Previously invisible copies showed as beige in the staff client, they stopped doing this in 2.0 This is because in 2.0 the copy counts logic was moved from open-ils.storage.biblio.record_entry.copy_count.staff to an in-database function wrapped in open-ils.search.biblio.record.copy_count.staff. Both methods returned various counts including an 'unshadow' count, however the 'unshadow' in the new database function was not completed and it has only been returning a simple copy count rather than a count of opac visible copies as it should be to replicate the old behaviour. Signed-off-by: James Fournie Signed-off-by: Lebbeous Fogle-Weekley 2011-10-06 Lebbeous Fogle-Weekley * Open-ILS/web/js/dojo/openils/acq/nls/acq.js, Open-ILS/web/js/ui/default/acq/common/li_table.js: Acq: better error message if trying to create PO without provider or agency Before now, if you leave either the provider or ordering agency fields blank in the "Create Purchase Order" dialog, you get a nonsensical warning about prepayment. This fixes that. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Bill Erickson 2011-11-03 Liam Whalen * Open-ILS/src/sql/Pg/1.6.1-2.0-upgrade-db.sql: Modified authority.indexing_ingest_or_delete to update MARC data The authority.indexing_ingest_or_delete trigger in the update script was missing a call to authority.propagate_changes which is responsible for updating the MARC data of records affected by an auhtority merge. This patch adds the call to authority.propagate_changes as it appears in the authority.indexing_ingest_or_delete trigger from the file 999.functions.global.sql. Signed-off-by: Liam Whalen Signed-off-by: Dan Scott 2011-10-21 Bill Erickson * Open-ILS/src/templates/conify/global/vandelay/match_set.tt2: Repair Vandelay match_set_tree link ctx.base_path includes the "/eg" portion of the path, so no need to duplicate that in the template. Signed-off-by: Bill Erickson Signed-off-by: Mike Rylander 2011-10-06 Lebbeous Fogle-Weekley * Open-ILS/web/js/ui/default/acq/common/li_table.js, Open-ILS/web/js/ui/default/acq/search/unified.js: Acq: fix a bug that sometimes prevents the general search page from loading Within Acquisitions General Search, javascript included from one file in the relies on the variable "localeStrings" being initialized by javascript included from a file in . Sometimes the wrong javascript wins the race, you get an error about localeStrings being undefined in the Javascript console, and the page stops loading. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Bill Erickson 2011-11-01 Bill Erickson * Open-ILS/src/support-scripts/fine_generator.pl: Fine generator; raise multi-session mode recv timeout When fetching the batch of overdue circ IDs to process for fine generation, wait a little longer for the data to arrive, since it is a longer running DB query than most. Signed-off-by: Bill Erickson Signed-off-by: Lebbeous Fogle-Weekley 2011-11-01 Jason Etheridge * Open-ILS/src/sql/Pg/002.schema.config.sql: forgot to update upgrade_log Signed-off-by: Jason Etheridge 2011-11-01 Jason Etheridge * Open-ILS/src/sql/Pg/upgrade/0645.schema.null_svf_protection.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.schema.null_svf_protection.sql: pin upgrade version number Signed-off-by: Jason Etheridge 2011-11-01 Mike Rylander * Open-ILS/src/sql/Pg/030.schema.metabib.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.schema.null_svf_protection.sql: Protect SVF normalizers against NULL values Signed-off-by: Mike Rylander Signed-off-by: Jason Etheridge 2011-11-01 Dan Scott * Open-ILS/src/perlmods/lib/OpenILS/WWW/AddedContent/Amazon.pm: Force Amazon AC requests to use 10-digit ISBNs Inspired by a patch submitted by Ian Bays via https://bugs.launchpad.net/evergreen/+bug/870171, this patch takes the incoming key and, if it is longer than 10 characters (a 10-digit ISBN or Amazon ID), attempts to normalize it and return a 10-digit ISBN. We don't normalize all incoming keys because some sites are horribly abusing the 020 MARC field to include an Amazon ID instead of an ISBN - but that works in practice and we'd rather not break working installations if we can avoid it. Signed-off-by: Dan Scott 2011-10-19 Jason Stephenson * Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm: Use ne on line 631 of Actor.pm. This is so that we stop getting errors like Argument "1319057146.8881216485.4819607085" isn't numeric in numeric ne (!=) at /usr/local/share/perl/5.10.1/OpenILS/Application/Actor.pm line 630. in /openils/var/log/open-ils.actor_stderr.log Signed-off-by: Jason Stephenson Signed-off-by: Dan Scott 2011-11-01 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm: Tpac; bookbag MARC retrieved via unapi Make sure the bookbag interface has access to metabib.record_attr's by retrieving and parsing the marcxml via unapi (get_records_and_facets). Signed-off-by: Bill Erickson Signed-off-by: Mike Rylander 2011-10-31 Dan Scott * Open-ILS/src/perlmods/lib/OpenILS/Utils/Cronscript.pm.in: Trivial whitespace touchup to Cronscript.pm.in Signed-off-by: Dan Scott 2011-10-31 Jason Stephenson * Open-ILS/src/perlmods/lib/OpenILS/Utils/Cronscript.pm.in: OpenILS::Utils::Cronscript can have only 1 session. Work around the above limitation by using OpenSRF::AppSession to create a session for open-ils.auth in the authenticate method. Also requires us to manually check if we're bootstrapped, since we can't rely on OpenILS::Utils::Cronscript->session to do it for us. Signed-off-by: Jason Stephenson Signed-off-by: Dan Scott 2011-10-31 Jason Stephenson * Open-ILS/src/perlmods/lib/OpenILS/Utils/Cronscript.pm.in: Add authentication capability to OpenILS::Utils::Cronscript. This allows the client script to call authenticate with a hash ref of user information so that the user can login and get an authtoken if needed. It also stores the authtoken and authtime values for later retrieval. Signed-off-by: Jason Stephenson Signed-off-by: Dan Scott 2011-10-31 Lebbeous Fogle-Weekley * Open-ILS/src/templates/opac/parts/result/lowhits.tt2, Open-ILS/web/css/skin/default/opac/style.css: Tpac: show staff saved searches on no-results page Not having it there is awkward for the user who relies on the feature and enters a search term that gets no results. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Bill Erickson 2011-10-27 Lebbeous Fogle-Weekley * Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader.pm, Open-ILS/src/templates/opac/parts/staff_saved_searches.tt2, Open-ILS/web/css/skin/default/opac/style.css: Tpac: staff saved searches expand/collapse, use right ou context for setting 1) Display staff saved searches collapsed by default. This makes the facet display right underneath it more accessible in the case of long search histories. 2) When checking the org unit setting for the limiting number of searches to save, use the user's ws_ou as the context, since this is a staff-client feature. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Bill Erickson 2011-10-27 Michael Peters * Open-ILS/examples/apache/eg.conf: A tweak to eg.conf to prevent against the BEAST exploit in TLS/SSL Based on recommedation from https://community.qualys.com/blogs/securitylabs/2011/10/17/mitigating-the-beast-attack-on-tlsSigned-off-by: Michael Peters Signed-off-by: Galen Charlton 2011-10-28 Lebbeous Fogle-Weekley * Open-ILS/src/templates/opac/myopac/holds/edit.tt2: Tpac: fix the doubly wrapped holds editor For some reason it must have made since in the past to wrap this interface in both parts/base.tt2 and myopac/parts/base.tt2, but nowadays that results in having extra headers and footers around the actual page contents, so the layout looks broken. This fixes that. No other interfaces were doing this double wrapping. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Bill Erickson 2011-10-28 Lebbeous Fogle-Weekley * Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader.pm, Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Record.pm, Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Search.pm, Open-ILS/src/perlmods/lib/OpenILS/WWW/Redirect.pm: Tpac: Rename orig_loc to physical_loc, for clarity's sake. This is an OPAC parameter not so much meant for use by patrons at home, but for users at machines physically located in libraries. In conjunction with OpenILS::WWW::Redirector, it helps those machines "remember" what branch they're in. Anyway, the name orig_loc doesn't make the parameter's meaning quite as clear as it could whne you encounter it in code. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Bill Erickson 2011-10-27 Lebbeous Fogle-Weekley * Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Util.pm: Tpac: clear the per-process cache of org-unit settings on each page load Any time saved is not worth the confusion of changes to org unit settings not taking effect in the TPAC without an apache restart, or worse, taking effect for some page loads but not others. Actually authored by Bill. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Bill Erickson 2011-10-28 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0644.data.YAOUS-target-when-closed.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.data.YAOUS-target-when-closed.sql: Stamping upgrade script for YAOUS-target-when-closed Signed-off-by: Mike Rylander 2011-09-28 Lebbeous Fogle-Weekley * Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/act ion.pm, Open-ILS/src/sql/Pg/950.data.seed-values.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.data.YAOUS-target-when-closed.sql: Add and use two YAOUS to allow hold targeting on copies at closed OUs One YAOUS completely ignores the closedness of the circ lib of the copy being tested for potential targeting. The other YAOUS ignores the closedness of the circ lib IFF the circ lib of the copy being tested matches the pickup lib of the hold request. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Mike Rylander 2011-10-27 Bill Erickson * Open-ILS/src/templates/opac/myopac/holds/edit.tt2: Tpac; holds edit page format icon improvements * Fixed the image path to the format_icon * Use the format_label as the title for the format_icon image Signed-off-by: Bill Erickson Signed-off-by: Lebbeous Fogle-Weekley 2011-10-27 Bill Erickson * Open-ILS/src/templates/opac/parts/coded_value_selector.tt2: TPac; sort coded value maps by label alphabetically Affects languages, formats, and audience. Signed-off-by: Bill Erickson Signed-off-by: Lebbeous Fogle-Weekley 2011-10-27 Bill Erickson * Open-ILS/src/templates/opac/myopac/circs.tt2: Tpac; style due-date red/error for overdue items In the patrons items out list, if an item is overdue, style the due date as "error" (i.e. bold red). Signed-off-by: Bill Erickson 2011-09-27 Jason Etheridge * Open-ILS/xul/staff_client/server/circ/checkin.js: LP#860685 List Actions and Print List fix List Actions and Print List broken in Check In interface when not using "Fast Entry (Asynchronous)", due to the way we're using list.refresh_row. This fixes the internal list state for tracking retrieved versus un-retrieved list rows. Signed-off-by: Jason Etheridge Signed-off-by: Mike Rylander 2011-10-14 Jason Etheridge * Open-ILS/web/js/ui/default/actor/user/register.js: LP874597 password from phone # when cloning users Patron: password from phone # does not work when cloning users Signed-off-by: Jason Etheridge Signed-off-by: Mike Rylander 2011-10-26 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Z3950.pm: Z39.50 service filter repairs Do not attempt to filter out Z39.50 services by permission when retrieveing the services in a non-authenticate manner (i.e. from within the Z39.50 code). Otherwise, the code will die on $e->requestor->id, because there is no requestor. Signed-off-by: Bill Erickson Signed-off-by: Jason Etheridge 2011-10-05 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Biblio.pm: Z39.50 local catalog fetch-more repairs Fixes the following problem: When paging through local catalog results in the Z39.50 interface, paging off then end of the local results would result in an unknown server error caused by trying to retrieve an empty list of records. $list->{count} in this context is the overall hit count, not the counts in the current page of results. Note also if {count} is zero, the list of IDs will be undef, so we use both. Signed-off-by: Bill Erickson Signed-off-by: Jason Etheridge 2011-08-26 Thomas Berezansky * Open-ILS/src/perlmods/lib/OpenILS/SIP/Transaction/Checkout.pm: SIP2 Checkout "no-code" failure fix Instead of assuming that code exists on a response do more checks. Specifically, a response code can be empty but not zero when there is no defined event code for the failure code. An easily tested case of this is standing penalties. Signed-off-by: Thomas Berezansky Signed-off-by: Bill Erickson 2011-10-26 Thomas Berezansky * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0643.data.populate_authority_simple_hea ding.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.data.populate_authority_simple_hea ding.sql: Stamping Upgrade script to populate authority.simple_heading Signed-off-by: Thomas Berezansky 2011-10-26 Mike Rylander * Open-ILS/src/sql/Pg/upgrade/XXXX.data.populate_authority_simple_hea ding.sql: Upgrade script to populate authority.simple_heading Signed-off-by: Mike Rylander Signed-off-by: Thomas Berezansky 2011-10-06 Lebbeous Fogle-Weekley * Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/Order.pm: Avoid a possible bug in selection list deletion This particularly matters for the "ephemeral," unnamed selection list that Acquisitions General Search uses to hold bib records represented as lineitems, as that list is deleted for the next run of that kind of search. It's possible to get lineitems onto that list that are in a state other than "new". Code that deletes this list first deletes the lineitems that belong to it, but that code formerly assumed that there are two types of lineitems. "new" ones (that should be deleted) and ones that belong to purchase orders (that should be deatched). That doesn't necessarily cover all possible lineitems on the picklist, so deletion ultimately fails. This fixes that. [update: now this bugfix incorporates a bugfix, the need for which was detected by Ben Shum. See LP #869581] Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Bill Erickson 2011-10-25 Mike Rylander * Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/Que ryParser.pm: Provide a QP modifier for sorting NULLS FIRST in the core SQL Signed-off-by: Mike Rylander 2011-10-19 Lebbeous Fogle-Weekley * Open-ILS/src/perlmods/lib/OpenILS/WWW/SuperCat.pm, Open-ILS/src/templates/opac/myopac/lists.tt2: Tiny bookbag improvements Bookbag feed item sort order now defined Bookbag list sort order on the "My Lists" page is now less agressively propagated Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Bill Erickson 2011-10-20 Bill Erickson * Open-ILS/src/templates/opac/myopac/hold_history.tt2, Open-ILS/src/templates/opac/myopac/holds.tt2: TPac; holds format icon follow-up fix 'bre' is no longer available to the templates. use bre_id instead. Signed-off-by: Bill Erickson Signed-off-by: Lebbeous Fogle-Weekley 2011-10-20 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm, Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm, Open-ILS/src/templates/opac/myopac/hold_history.tt2, Open-ILS/src/templates/opac/myopac/holds.tt2: Tpac; repair format icon display in holds lists * Fetch MARC XML from unapi to pick up metabib::record_attr's for each record. * Update format icon code in holds list to use new-style precompiled format_icon Signed-off-by: Bill Erickson Signed-off-by: Lebbeous Fogle-Weekley 2011-10-19 Lebbeous Fogle-Weekley * Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm: TPAC: avoid problem with HOLD_EXISTS event in hold placement If you place a hold on something that generates a HOLD_EXISTS event (and no other events?) you get a 500 error from Apache and an error in the logs saying "not a hash reference" about $result in the lines I've changed here. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Bill Erickson 2011-10-19 Bill Erickson * Open-ILS/src/templates/opac/myopac/hold_history.tt2: TPac; use canned get_hold_status call for history UI For consistency, use the same get_hold_status BLOCK to determine holds status display in the holds history UI. Signed-off-by: Bill Erickson Signed-off-by: Lebbeous Fogle-Weekley 2011-10-16 Dan Scott * Open-ILS/src/perlmods/lib/OpenILS/WWW/SuperCat.pm: LP875819: Fix SRU and Z39.50 default search index failures Per http://www.loc.gov/standards/sru/specs/cql.html : All parts of CQL are case insensitive [...] If any case insensitive part of CQL is specified with both upper and lower case, it is for aesthetic purposes only. So fold the SRU qualifier and relation to lower case. This then matches the srw.serverchoice entry that we already have in config.metabib_search_alias so that default searches will successfully point to the keyword index. Signed-off-by: Dan Scott Signed-off-by: Lebbeous Fogle-Weekley 2011-10-19 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm: TPac; Fetch authoritative user object in my-account Since user data changes in my-account, any time we fetch the fleshed user object, fetch it within a transaction to avoid retrieval from a (potentially lagging) DB replica. Signed-off-by: Bill Erickson Signed-off-by: Lebbeous Fogle-Weekley 2011-10-19 Dan Scott * README: Fix README issues Martha Driscoll noted that the create_database.sql script wasn't actually targeted by the psql command, and also that there was an extraneous tag in the OpenSRF start command. Signed-off-by: Dan Scott 2011-10-19 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/Utils/CStoreEditor.pm: CStoreEditor batch_retrieve repairs 1. If the caller provides additional cstore params, like flesh, flesh_fields, etc. make sure we only use the first component of the search (the list of identifier values) for the cstore search. 2. Determine the identifier field from the class being retrieved instead of hard-coding it to be "id" Signed-off-by: Bill Erickson Signed-off-by: Lebbeous Fogle-Weekley 2011-09-20 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Reactor.pm, Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/950.data.seed-values.sql, Open-ILS/src/sql/Pg/upgrade/0642.data.acq-worksheet-hold-count.sql: ACQ: Add open holds count to lineitem worksheet Includes a generic bre_open_holds_count reactor utility method Signed-off-by: Bill Erickson Signed-off-by: Lebbeous Fogle-Weekley 2011-10-19 Lebbeous Fogle-Weekley * : TPac: Put staff saved searches in same div as facets on the results page Also: make a minor improvement to bookbag sorting clicking heading sort links a second time reverses order. And on the record page, make them less ugly. We need to get rid of this 974-px-wide business. It's ridiculous, and it keeps us busy fighting CSS just to keep a silly grey margin on the right side of the display, and it keeps us from using all available space. We need to simplify the CSS greatly, in fact. Let's bite that bullet sooner than later. Signed-off-by: Lebbeous Fogle-Weekley 2011-10-18 Lebbeous Fogle-Weekley * Open-ILS/src/templates/opac/parts/result/table.tt2, Open-ILS/src/templates/opac/results.tt2, Open-ILS/web/css/skin/default/opac/style.css: TPac: Put staff saved searches in same div as facets on the results page And on the record page, make them less ugly. We need to get rid of this 974-px-wide business. It's ridiculous, and it keeps us busy fighting CSS just to keep a silly grey margin on the right side of the display, and it keeps us from using all available space. We need to simplify the CSS greatly, in fact. Let's bite that bullet sooner than later. Signed-off-by: Lebbeous Fogle-Weekley 2011-10-18 Mike Rylander * Open-ILS/src/templates/opac/myopac/lists.tt2, Open-ILS/src/templates/opac/parts/filtersort.tt2: remove the Sort by Relavance option from the bookbag sort options Signed-off-by: Mike Rylander Signed-off-by: Lebbeous Fogle-Weekley 2011-10-18 Galen Charlton * Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm: add a couple semicolons Not strictly required, but may as well save a picosecond of grief for the next person who adds to this code. Signed-off-by: Galen Charlton 2011-09-15 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm: Create events for hold_request.cancel.patron When a patron cancels his/her own hold, create events for the (already-existing) hold_request.cancel.patron A/T hook. Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 2011-10-18 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm: Re-fetch hold for cancel notify to correct timestamp Re-fetch the cancelled hold from the DB before passing it off to action/trigger for notification processing. Otherwise, A/T attempts to perform date math on "now" instead of a valid timestamp and subsequently croaks. Signed-off-by: Bill Erickson Signed-off-by: Lebbeous Fogle-Weekley 2011-10-16 Dan Scott * Open-ILS/src/perlmods/lib/OpenILS/Application/Fielder.pm: Cache open-ils.fielder results by locale The problem was particularly visible in search facets, but existed before: the cache key used for fielder results did not take locale into account, so on a multi-locale system the first locale won and populated the cache for all other locales. Use a session locale if provided, otherwise default to the locale set in opensrf.xml Signed-off-by: Dan Scott Signed-off-by: Thomas Berezansky 2011-10-18 Mike Rylander * Open-ILS/src/templates/opac/myopac/lists.tt2: Add a view-in-catalog link to bookbags Signed-off-by: Mike Rylander Signed-off-by: Lebbeous Fogle-Weekley 2011-09-14 Sarah E. Chodrow * Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm: Initial patch from Sarah Chodrow on LP bug 849447. Also check for standing penalties and expired cards when checking if it is ok for the patron to checkout, charge_ok. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. Signed-off-by: Sarah E. Chodrow (sarah.chodrow@bibliotheca-itg.com) Signed-off-by: Jason Stephenson Signed-off-by: Thomas Berezansky 2011-10-18 Thomas Berezansky * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0641.schema.org_unit_setting_json_check .sql, Open-ILS/src/sql/Pg/upgrade/XXXX.schema.org_unit_setting_json_check .sql: Stamping upgrade script for LP#847973 Signed-off-by: Thomas Berezansky 2011-09-12 Jason Etheridge * Open-ILS/src/sql/Pg/005.schema.actors.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.schema.org_unit_setting_json_check .sql: LP#847973 ensure JSON values for org settings I don't believe you can violate this constraint via the Library Settings UI, but this will catch speedy-admins mucking directly in the database. Signed-off-by: Jason Etheridge Signed-off-by: Thomas Berezansky 2011-10-17 Dan Scott * Open-ILS/src/templates/opac/myopac/lists.tt2, Open-ILS/web/css/skin/default/opac/style.css: TPac: Describe bookbags mo' semantically Rather than "big-strong", use a heading (H2, as the previously used H2 headings got bumped to H1) and wrap the description in a styled DIV rather than just dumping it after a
and wrapping it in . Signed-off-by: Dan Scott 2011-10-14 Lebbeous Fogle-Weekley * Open-ILS/src/perlmods/lib/OpenILS/Application/AppUtils.pm, Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm, Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Container.pm, Open-ILS/src/templates/opac/myopac/lists.tt2, Open-ILS/src/templates/opac/parts/anon_list.tt2, Open-ILS/src/templates/opac/parts/filtersort.tt2, Open-ILS/web/css/skin/default/opac/style.css: TPac: bookbags - stop trying to show everything at once Go back to displaying one bookbag at a time (not counting the temporary list, when that is populated) This hopefully constitutes a usability improvement. While it doesn't provide paging of bookbags themselves or of the items therein, it should make that easier to do. Showing all bookbags and all their items made it nonobvious how paging would even be expected to behave. This also provides the same sorting for the items in the temporary list as in real bookbags. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Dan Scott 2011-10-17 Dan Scott * Open-ILS/web/opac/locale/en-US/lang.dtd: Typo: It's MARC, not Marc. Sheesh. Signed-off-by: Dan Scott 2011-09-14 Thomas Berezansky * Open-ILS/xul/staff_client/server/cat/marc_new.xul: Save MARC Default Template per-server In case you use multiple servers with different template lists Signed-off-by: Thomas Berezansky Signed-off-by: Dan Scott 2011-09-14 Thomas Berezansky * Open-ILS/web/opac/locale/en-US/lang.dtd, Open-ILS/xul/staff_client/server/cat/marc_new.xul, Open-ILS/xul/staff_client/server/locale/en-US/cat.properties: Remember MARC Template selection Implement both a workstation default and "last used" for the MARC template selector. Workstation default is set with a new "Set Workstation Default" button. "Last used" will override the workstation default, and is updated every time you load a template. It is forgotten when you close the client. Signed-off-by: Thomas Berezansky Signed-off-by: Dan Scott 2011-10-04 Thomas Berezansky * Open-ILS/web/opac/skin/default/js/adv_global.js: Add "submit on enter" to all advanced search boxes Instead of just the one with an ID specified. Signed-off-by: Thomas Berezansky Signed-off-by: Dan Scott 2011-10-14 Bill Erickson * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0640.schema-acs-nfi.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.schema-acs-nfi.sql: Stamped upgrade scrip fro authorities-indb-with-nfi Signed-off-by: Bill Erickson 2011-10-11 Mike Rylander * Open-ILS/src/sql/Pg/002.functions.config.sql, Open-ILS/src/sql/Pg/020.schema.functions.sql: Move the NACO normalization script to earlier in the baseline schema installation process, as it is now used in the authority schema Signed-off-by: Mike Rylander Signed-off-by: Bill Erickson 2011-10-07 Mike Rylander * Open-ILS/src/sql/Pg/upgrade/XXXX.schema-acs-nfi.sql: Wrapper functions in the baseline schema that were missed in the upgrade script Signed-off-by: Mike Rylander Signed-off-by: Bill Erickson 2011-10-07 Mike Rylander * Open-ILS/src/sql/Pg/011.schema.authority.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.schema-acs-nfi.sql: Address regression causing main headings to be null because the thesaurus code we not being extracted as it was before Signed-off-by: Mike Rylander Signed-off-by: Bill Erickson 2011-09-21 Mike Rylander * Open-ILS/examples/fm_IDL.xml, Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/aut hority.pm, Open-ILS/src/perlmods/lib/OpenILS/Application/SuperCat.pm, Open-ILS/src/perlmods/lib/OpenILS/WWW/SuperCat.pm, Open-ILS/src/sql/Pg/011.schema.authority.sql, Open-ILS/src/sql/Pg/950.data.seed-values.sql, Open-ILS/src/sql/Pg/999.functions.global.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.schema-acs-nfi.sql, Open-ILS/xul/staff_client/server/cat/marcedit.js: New in-db search and browse of authorities with non-filing-indicator support Upon authority ingest, record simple authority headings for searching, browsing and sorting. Respect non-filing indicators, if configured (configuration is the nfi field on authority.control_set_authority_field). Provide a full suite of search/browse top/center alpha/rank functions based on authority tag, bib tag or browse axis at the database layer. Provide functions to find the main-only and full tag list, and ref-variant versions of the previously defined functions. Teach OpenILS::WWW::SuperCat (responsible for RESTful feed-generating interfaces) to use new OpenILS::Application::SuperCat methods that in turn use the database methods. The change should be transparent to users of SuperCat web APIs. Carry indicators over from authority main entries to bibs, when applying them in the marc editor. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Bill Erickson 2011-10-14 Jason Etheridge * Open-ILS/xul/staff_client/server/patron/bill2.js: LP873614 print_init error printing bill history xulG.url_prefix needs to be present for anything using util/print.js and the Mozilla print strategy. Alternately, we could duplicate the logic behind url_prefix and bundle it into print.js :-/ Signed-off-by: Jason Etheridge Signed-off-by: Jason Stephenson Signed-off-by: Dan Scott 2011-10-13 Dan Scott * Open-ILS/src/support-scripts/settings-tester.pl: settings-tester.pl - add TPac required modules Keep up with the TPac requirements in settings-tester.pl Signed-off-by: Dan Scott 2011-10-13 Dan Scott * Open-ILS/src/support-scripts/settings-tester.pl: Add MARC::Record 2.0.1 minimum test to settings-tester.pl Wrap the use_ok() tests in a BEGIN block, per the recommendation of the Test::More perldoc. Signed-off-by: Dan Scott 2011-10-13 Dan Scott * Open-ILS/src/support-scripts/settings-tester.pl: Settings-tester.pl whitespace Might as well complete the conversion of the file into modernity. Signed-off-by: Dan Scott 2011-10-13 Dan Scott * Open-ILS/src/support-scripts/settings-tester.pl: Remove oils_web.xml test from settings-tester.pl In master, oils_web.xml is no more, replaced instead by Apache configuration. Awww yeah. Signed-off-by: Dan Scott 2011-10-13 Dan Scott * Open-ILS/src/support-scripts/settings-tester.pl: Modernize settings-tester.pl a bit * Add a section that checks for Evergreen services in opensrf_core.xml * Ignore the qstore database credentials, as qstore is unused currently * Split things off into subroutines for easier reading Signed-off-by: Dan Scott 2011-09-22 Jason Stephenson * Open-ILS/src/perlmods/lib/OpenILS/SIP/Transaction/FeePayment.pm: Fixes for SIP2 Fee Payment. Skip negative or zero bill balance when paying multiple bills. Log amount paid, bill id, balance, and amount remaining when paying multiple bills. Use sprintf("%.2f") to avoid floating point errors. Signed-off-by: Jason Stephenson Signed-off-by: Dan Scott 2011-10-13 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0639.schema.asset_merge_record_assets.s ql, Open-ILS/src/sql/Pg/upgrade/XXXX.schema.asset_merge_record_assets.s ql: Stamping upgrade for asset.merge_record_assets fix from dbs Signed-off-by: Mike Rylander 2011-10-13 Dan Scott * Open-ILS/src/sql/Pg/999.functions.global.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.schema.asset_merge_record_assets.s ql: Fix located URI merging in action.merge_record_assets() Perhaps due to the unexpected results of the XPath expression, which returns a count of nodes for subfields, etc, rather than just a count of the number of 856 datafields, NULL was being concatenated onto a string - which of course made the string NULL. Use COALESCE() to prevent the NULLness from spreading and enable action.merge_record_assets() to do the right thing. Signed-off-by: Dan Scott Signed-off-by: Mike Rylander 2011-09-27 Thomas Berezansky * Open-ILS/src/templates/acq/invoice/view.tt2, Open-ILS/src/templates/acq/lineitem/findbib.tt2, Open-ILS/src/templates/acq/lineitem/related.tt2, Open-ILS/src/templates/acq/lineitem/worksheet.tt2, Open-ILS/src/templates/acq/picklist/brief_record.tt2, Open-ILS/src/templates/acq/picklist/list.tt2, Open-ILS/src/templates/acq/picklist/user_request.tt2, Open-ILS/src/templates/acq/po/view.tt2, Open-ILS/src/templates/acq/search/unified.tt2, Open-ILS/src/templates/actor/user/register.tt2, Open-ILS/src/templates/circ/selfcheck/main.tt2, Open-ILS/src/templates/conify/global/action_trigger/event_definitio n_data.tt2, Open-ILS/src/templates/conify/global/asset/copy_location_order.tt2, Open-ILS/src/templates/conify/global/config/barcode_completion.tt2, Open-ILS/src/templates/conify/global/config/circ_matrix_matchpoint. tt2, Open-ILS/src/templates/conify/global/config/coded_value_map.tt2, Open-ILS/src/templates/vandelay/inc/progress.tt2, Open-ILS/src/templates/vandelay/inc/queue.tt2, Open-ILS/src/templates/vandelay/inc/upload.tt2, Open-ILS/web/conify/global/actor/org_unit.html, Open-ILS/web/conify/global/admin.html, Open-ILS/web/js/dojo/openils/widget/GridColumnPicker.js, Open-ILS/web/js/dojo/openils/widget/TranslatorPopup.js, Open-ILS/web/reports/oils_rpt.xhtml, Open-ILS/web/reports/oils_rpt_builder.xhtml, Open-ILS/web/reports/oils_rpt_editor.xhtml, Open-ILS/web/reports/oils_rpt_folder_window.xhtml, Open-ILS/web/reports/oils_rpt_param_editor.xhtml, Open-ILS/xul/staff_client/server/admin/cash_reports.xhtml, Open-ILS/xul/staff_client/server/admin/closed_dates.xhtml, Open-ILS/xul/staff_client/server/admin/copy_locations.xhtml, Open-ILS/xul/staff_client/server/admin/hold_pull_list.xhtml, Open-ILS/xul/staff_client/server/admin/hold_pull_list_classic.xhtml , Open-ILS/xul/staff_client/server/admin/non_cat_types.xhtml, Open-ILS/xul/staff_client/server/admin/org_unit_settings.xhtml, Open-ILS/xul/staff_client/server/admin/stat_cat_editor.xhtml, Open-ILS/xul/staff_client/server/patron/ue.xhtml, Open-ILS/xul/staff_client/server/patron/user_edit.xhtml: More self-closing cleanup All div and span tags in tt2, js, html, and xhtml files. Ignored .xml files, as they are not (to my knowledge) served as text/html. Signed-off-by: Thomas Berezansky Signed-off-by: Dan Scott 2011-09-27 Bill Erickson * Open-ILS/src/templates/conify/global/config/hold_matrix_matchpoint. tt2, Open-ILS/src/templates/vandelay/inc/attrs.tt2, Open-ILS/src/templates/vandelay/inc/queue.tt2: Replace self-closing divs with open/close divs XML != HTML Traditionally, Vandelay templates were parsed as XML on the server for DTD replacement. With the advent of locale::maketext for templates, Vandelay no longer needs to be parsed as XML. However, not parsing as XML leaves any self-closing divs (
) intact in the final source, which are treated as opening divs in text/html. This patch replaces self-closing divs with open/close pairs. https://bugs.launchpad.net/evergreen/+bug/860676 Signed-off-by: Bill Erickson Signed-off-by: Dan Scott 2011-09-26 Jason Stephenson * Open-ILS/src/perlmods/lib/OpenILS/SIP.pm: Verify session before trying any transactions in SIP->pay_fee. Signed-off-by: Jason Stephenson Signed-off-by: Dan Scott 2011-10-12 Lebbeous Fogle-Weekley * Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm, Open-ILS/src/templates/opac/myopac/lists.tt2: TPac: One prefers to download CSV, not to display it For the "Download CSV" operation in the TPac "My Lists" interface, provoke the user's browser to download the file, rather than displaying the file in a new tab/window. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Dan Scott 2011-10-12 Dan Scott * Open-ILS/xul/staff_client/server/index.xhtml: Give OrgTree.js a locale, always We started generating locale-specific OrgTree.js files many moons ago, and now no longer provide a "default" locale in the root of the common/js directory. The result was that the index.xhtml page for the staff client was throwing an "_l is undefined" exception; largely meaningless, as it seems that the OrgTree isn't even used on that page, but noise that doesn't need to be in the JavaScript console. Here we correct that exception by providing a locale, and hopefully prevent any further copy/paste mistakes. Signed-off-by: Dan Scott 2011-10-11 Bill Erickson * Open-ILS/src/c-apps/oils_auth.c: Authentication block logging * Login too-many-auth-failures message at Info level instead of Internal * Log the username getting blocked Signed-off-by: Bill Erickson Signed-off-by: Galen Charlton 2011-10-12 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/990.schema.unapi.sql, Open-ILS/src/sql/Pg/upgrade/0638.schema.unapi.sitem-fix.sql: Fix cut-paste-o in unapi.sitem, re stream and unit subobjects~ Signed-off-by: Mike Rylander 2011-10-12 Mike Rylander * Open-ILS/src/sql/Pg/upgrade/0637.schema.renewal_checkout_counting.s ql: Incorrect version number in the upgrade script Signed-off-by: Mike Rylander 2011-10-12 Mike Rylander * Open-ILS/src/sql/Pg/upgrade/0636.data.grace_period_extend.sql: copy-paste-o from the seed data Signed-off-by: Mike Rylander 2011-09-16 Jason Stephenson * Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Biblio.pm: Fix z39.50 import isbn and issn searches on local catalog. Make cat_search_z_style_wrapper do identifier searches for isbn and issn. Modify the_quest_for_knowledge to accept identifier searches for isbn and issn. Signed-off-by: Jason Stephenson Signed-off-by: Dan Scott 2011-09-16 Jason Stephenson * Open-ILS/xul/staff_client/server/cat/z3950.js, Open-ILS/xul/staff_client/server/cat/z3950.xul: Add Show In Catalog button to Z39.50 Import. Changes to z3950.xul: Add show_in_catalog command. Add button next to Mark for Overlay button. Changes to z3950.js: Enable/disable Show In Catalog button whenever Mark for Overlay button is enabled/disabled. Add code for show_in_catalog to open the record detail screen in a new tab. Signed-off-by: Jason Stephenson Signed-off-by: Dan Scott 2011-10-12 Dan Scott * README: README: For master, focus on PostgreSQL 9.1 Given that the backports for Debian and Ubuntu already offer PostgreSQL 9.1, and Fedora 16 (out in a few weeks) comes with 9.1, focus on 9.1 where it is available. Signed-off-by: Dan Scott 2011-10-12 Thomas Berezansky * Open-ILS/src/extras/Makefile.install, README: Add instructions/targets for Ubuntu/Debian PG9.1 No Fedora/RHEL/CentOS changes due to my lack of test environment. Signed-off-by: Thomas Berezansky Signed-off-by: Dan Scott 2011-10-12 Thomas Berezansky * README: Fix README for 9.1+ DB creation instructions Also fix 9.0 typo of - instead of _ in filename. Signed-off-by: Thomas Berezansky Signed-off-by: Dan Scott 2011-10-11 Dan Scott * README: README: Minor whitespace cleanup Just to get the indentation standardized on second and subsequent lines of bullets. No big whoop. Signed-off-by: Dan Scott 2011-10-11 Ben Shum * README: Change PostgreSQL 9 source for Ubuntu Lucid users. Currently, Ubuntu Lucid does not have backport options for PostgreSQL 9. Instead, most community members who use Lucid have been using Martin Pitt's PPA as an external repository source. Signed-off-by: Ben Shum Signed-off-by: Dan Scott 2011-10-11 Thomas Berezansky * Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader.pm: TPac: Use workstation to determine staff Instead of user agent, which may be set easily by anyone, use the presence of a workstation ID to determine "staff" use of the TPac. This is much less likely to be spoofed or incorrect due to things like previous use of the extension version of the client in Firefox. Signed-off-by: Thomas Berezansky Signed-off-by: Bill Erickson 2011-10-11 Bill Erickson * Open-ILS/src/templates/opac/parts/advanced/global_row.tt2: TPac; repairs to advanced search query propagation In some cases, TPac will duplicate components of an advanced search query into the advanced search rows. This patch fixes that with better array handling, particularly with CGI param search components that do not have corresponding analogs at a given array position (i.e. starting out with arrays of different sizes) Signed-off-by: Bill Erickson 2011-09-07 Dan Scott * Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm: Protect against undefined value as ARRAY reference We should not assume that the caller is going to supply an array (empty or not) of addresses or cards in the input values for the open-ils.actor.patron.update method. Signed-off-by: Dan Scott Signed-off-by: Galen Charlton 2011-09-25 Galen Charlton * Open-ILS/tests/datasets/edi_scratch/baker_taylor.ordrsp.jedi.pl: fix another POD glitch Signed-off-by: Galen Charlton Signed-off-by: Dan Scott 2011-09-25 Galen Charlton * Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/Picklist.pm, Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher.pm, Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/bib lio.pm, Open-ILS/src/perlmods/lib/OpenILS/Utils/CStoreEditor.pm, Open-ILS/src/perlmods/lib/OpenILS/Utils/ModsParser.pm, Open-ILS/src/perlmods/lib/OpenILS/WWW/Redirect.pm, Open-ILS/src/perlmods/xt/author/pod.t: fix up POD - avoids some noise when building the Perl modules for distributions that check for correctness when converting POD to man pages - add a an author test, taken straight from the Test::Pod documentation, for POD correctness Signed-off-by: Galen Charlton Signed-off-by: Dan Scott 2011-10-11 Galen Charlton * : Merge remote branch 'working/user/berick/marc-stream-importer-read-repair' Signed-off-by: Galen Charlton 2011-10-10 Dan Scott * Open-ILS/src/extras/Makefile.install: Fix broken Net::Z3950::SimpleServer 1.14 install Pin the install of Net::Z3950::SimpleServer to the known-to-work-with yaz 3.0.x version, 1.12. 1.14 introduced dependencies on yaz 4.1.x that can't be easily worked around. Signed-off-by: Dan Scott Signed-off-by: Galen Charlton 2011-07-21 Dan Scott * Open-ILS/src/extras/Makefile.install: Correct varname for PostgreSQL RPMs On Fedora, Red Hat, and CentOS, we were still trying to install the set of PostgreSQL RPMs for PostgreSQL 8.4 using PGSQL_84_RPMS. This had been updated to PGSQL_90_RPMS to match the updated database version - using the right varname resolves the problem (at least on Fedora). Signed-off-by: Dan Scott Signed-off-by: Thomas Berezansky 2011-10-10 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql: Stamping baseline schema for previous commit Signed-off-by: Mike Rylander 2011-10-10 Mike Rylander * Open-ILS/src/sql/Pg/100.circ_matrix.sql, Open-ILS/src/sql/Pg/upgrade/0637.schema.renewal_checkout_counting.s ql: Fix, as provided by Doug Kyle, for LP#822918 Signed-off-by: Mike Rylander 2011-10-10 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0636.data.grace_period_extend.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.data.grace_period_extend.sql: Stamped upgrade script for Grace Period Closed-Date Extension features Signed-off-by: Mike Rylander 2011-09-15 Thomas Berezansky * Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm, Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/act ion.pm, Open-ILS/src/sql/Pg/950.data.seed-values.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.data.grace_period_extend.sql: Grace period auto extension and backdate awareness Grace period auto extension: Default is "grace periods don't auto extend". OU setting turns on grace period auto extension. By default they only do so when the grace period ends on a closed date, but there are two modifiers to change that. The first modifier causes grace periods to extend for all closed dates that they intersect. This is "grace periods are only consumed by open days." The second modifier causes a grace period that ends just before a closed day, with or without extension having happened, to include the closed day (and any following it) as well. This is mainly so that a backdate into the closed period following the grace period will assume the "best case" of the item having been returned after hours on the last day of the closed date. Backdate grace period awareness: By moving grace period calculations into a shared location backdating can check the grace period, including extensions. If it finds that the backdate is within the grace period (before or after extension) then instead of voiding the fines for after the backdate it instead voids all fines for the circulation. This emulates what would have happened (no fines) if the item had been checked in at the time the backdate was made to take effect. Signed-off-by: Thomas Berezansky Signed-off-by: Mike Rylander 2011-10-07 Galen Charlton * Open-ILS/src/templates/conify/global/config/coded_value_map.tt2: trival typo fix Signed-off-by: Galen Charlton 2011-10-07 Jason Etheridge * Open-ILS/xul/staff_client/server/skin/custom.js.example: control client dump statements through pref Signed-off-by: Jason Etheridge 2011-10-07 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Search.pm: TPac: Jump-to-details on first result page only When activated, jump-to-record-details-on-1-hit should only come into play on the first page of results. In other words, if page 2 of a search has 1 item, do not jump to the record details page for that item. Instead, show page 2 of the search results. Signed-off-by: Bill Erickson 2011-10-06 Bill Erickson * Open-ILS/src/templates/opac/parts/result/facets.tt2: TPac; start new facet "search" on page 0 When selecting a facet, thereby appending it to the current search, start the search over at the first page. In other words, don't drop into page X of a new search, since there may be no page X of the new search. Signed-off-by: Bill Erickson 2011-10-06 Galen Charlton * Open-ILS/src/c-apps/oils_auth.c: fix authentication failure Ensure that the auth_limit values are read when open-ils.auth initializes, not during oilsAuthInit(). This solves a problem observed on brick-based setups where authentication could incorrectly fail because the drone that processes open-ils.auth.authenticate.complete didn't have the the block count value initialized yet. Also fixed type nit when compare the fail count to the block limit. Signed-off-by: Galen Charlton Signed-off-by: Bill Erickson 2011-09-30 Thomas Berezansky * Open-ILS/xul/staff_client/server/patron/place_hold.js: Fix "0 holds created" message on successful hold Caused by results not always being an array. Signed-off-by: Thomas Berezansky Signed-off-by: Dan Scott 2011-10-06 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Container.pm: TPac: My List add/remove page anchor fix Removed /g modifier from URL anchor regex to prevent URLs with multiple page #-anchors. This change primarily affects IE which includes #-anchors in the referer header. Signed-off-by: Bill Erickson 2011-10-04 Lebbeous Fogle-Weekley * Open-ILS/web/js/ui/default/acq/common/li_table.js, Open-ILS/web/js/ui/default/acq/common/li_table_pager.js, Open-ILS/web/js/ui/default/acq/search/unified.js: Really add *entire* selection list to a purchase order, when desired, and generally do what a user would expect when, in Acq, the user executes an operation on "all items". This addresses LaunchPad bug #810030. The fundamental issue is that an AcqLiTable, which is used in several different ways in different interfaces, may be representing items on a selection list (for example), but it doesn't necessarily know all of the items that belong to that selection list. It only knows what it has drawn. This addresses that deficiency by teaching the getSelected() method some new tricks so that it can consult the server in the various ways appropriate to getting a list of /all/ the items on a selection list, a purchase order, a virtual PO, a set of search results, etc. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Mike Rylander 2011-10-05 Dan Scott * README: Fix copy-paste-o: "su - postgres" to become postgres Thanks to sal_ in IRC who caught this nugget! Signed-off-by: Dan Scott 2011-10-05 Dan Scott * README: README: Explicitly identify accounts for commands Add a preamble to the beginning listing all of the accounts referenced in the instructions (Linux accounts, PostgreSQL accounts, Evergreen administrator accounts). Also move the Developer Instructions to the start to follow the natural order of operations. Signed-off-by: Dan Scott 2011-10-05 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Biblio.pm: Avoid collecting facet data for non-facet fields If a config.metabib_field (Admin -> Server Admin -> MARC Search/Facet Fields) starts out as a facet field but is later changed, data for that facet can still bubble up since it has already been extracted. This patch prevents facets for config.metabib_field entries whose facet_field=false from getting collected/cached for search results. Signed-off-by: Bill Erickson Signed-off-by: Lebbeous Fogle-Weekley 2011-10-04 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Search.pm, Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/950.data.seed-values.sql, Open-ILS/src/sql/Pg/upgrade/0635.data.opac.jump-to-details-setting. sql: TPac: jump to details page on single hit When enabled, any time an OPAC search yields 1 result, the user will be redirected to the record detail page for that result. This change adds 2 new org unit settings, one to control the behavior in the staff client, the other to control the public catalog. Signed-off-by: Bill Erickson Signed-off-by: Lebbeous Fogle-Weekley 2011-10-04 Dan Scott * Open-ILS/web/opac/locale/en-US/lang.dtd: Fix typo in lang.dtd: "instantenous" Signed-off-by: Dan Scott 2011-10-04 Dan Scott * build/i18n/po/lang.dtd/es-ES.po: i18n: Fix es-ES illegal use of '%' in lang.dtd The '%' character is used to include previously defined blocks in DTD files; would be nice if translate-toolkit gave a more obvious error to alert us to this rather than saying the en-US doesn't validate and dying. Signed-off-by: Dan Scott 2011-10-04 Dan Scott * Open-ILS/xul/staff_client/chrome/content/main/about.html: Slightly updated about.html for rel_2_1 Not sure we want to actually keep listing individuals in this file - there's a lot more credit to spread around - but at least I can bring it somewhat up to date with current info. Signed-off-by: Dan Scott Signed-off-by: Mike Rylander 2011-10-04 Jason Etheridge * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0634.security_lockdown.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.security_lockdown.sql: pin version for upgrade script Signed-off-by: Jason Etheridge 2011-08-15 Thomas Berezansky * Open-ILS/src/sql/Pg/upgrade/XXXX.security_lockdown.sql: Unwrapped upgrade script for security lockdown Signed-off-by: Thomas Berezansky Signed-off-by: Jason Etheridge 2011-08-15 Thomas Berezansky * Open-ILS/src/sql/Pg/950.data.seed-values.sql, Open-ILS/xul/staff_client/chrome/content/OpenILS/util_overlay_chrom e.xul, Open-ILS/xul/staff_client/chrome/content/OpenILS/util_overlay_offli ne.xul, Open-ILS/xul/staff_client/chrome/content/auth/controller.js, Open-ILS/xul/staff_client/chrome/content/main/main.js, Open-ILS/xul/staff_client/chrome/content/main/menu.js, Open-ILS/xul/staff_client/chrome/content/main/menu_frame_menus.xul, Open-ILS/xul/staff_client/server/OpenILS/util_overlay.xul: Require permission or pref to debug in client Disables all debug functions I know of unless: 1 - You have new DEBUG_CLIENT permission (after login) This should work even on operator change. Once a given debug interface is open you can change operator back. 2 - You have a client with the debug preference enabled This causes the client in all places I touched to think you have DEBUG_CLIENT This also allows debugging *before* login, including in the Standalone interface. Debug functions I know of: Debug box on login page (already protected by pref) Debug items in Admin menu Venkman Javascript Shells Inspector Chrome List CTRL+SHIFT+F7 debug box in overlays Signed-off-by: Thomas Berezansky Signed-off-by: Jason Etheridge 2011-08-12 Thomas Berezansky * Open-ILS/xul/staff_client/chrome/content/auth/controller.js: Clear password from password_prompt post-login Otherwise it remains as the plain text value. Signed-off-by: Thomas Berezansky Signed-off-by: Jason Etheridge 2011-10-04 Dan Scott * build/i18n/po/lang.dtd/ru-RU.po: i18n: Fix ru-RU lang.dtd problem No ampersands at the end of a string! Breaks moz2po horribly. Signed-off-by: Dan Scott 2011-10-04 Jason Etheridge * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0633.new_print_method.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.new_print_method.sql: pin version for upgrade script Signed-off-by: Jason Etheridge 2011-09-12 Thomas Berezansky * Open-ILS/xul/staff_client/chrome/content/util/print.js, Open-ILS/xul/staff_client/chrome/content/util/print_win.js: Switch to Modal printing Prevents an OS-level race condition on window focus. Signed-off-by: Thomas Berezansky Signed-off-by: Jason Etheridge 2011-08-24 Thomas Berezansky * Open-ILS/src/sql/Pg/upgrade/XXXX.new_print_method.sql: Unwrapped upgrade script for print.custom_js_file Signed-off-by: Thomas Berezansky Signed-off-by: Jason Etheridge 2011-08-24 Thomas Berezansky * Open-ILS/src/sql/Pg/950.data.seed-values.sql, Open-ILS/xul/staff_client/chrome/content/util/print.js, Open-ILS/xul/staff_client/chrome/content/util/print_win.js: Remove in-template javascript, add script files Adds support for a print_custom.js file and an org unit specified file. If either exists and contains a print_custom function it will be called before printing to allow for DOM manipulation. If neither exists the print_win.js file will call all functions it has defined. In addition, if any code sets do_print to false the window will close instead of attempting to print. The print_custom function will receive the type of template used, if any. This only applies to "Receipt Template" based print jobs, and the type in question is the "Type" that shows in the template editor. Functions defined in print_win.js: print_init Main function, checks for print_custom and does final printing print_do_sums Does summing of values. print_check_alt Does swapping out of template blocks with display:none styling. print_check_noprint Disables printing under certain circumstances. For more information about usage of the print_do_sums, print_check_alt, and print_check_noprint functions check the comments in print_win.js. Signed-off-by: Thomas Berezansky Signed-off-by: Jason Etheridge 2011-10-04 Bill Erickson * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0632.data.username-limit-settings.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.temp.sql: Stamped upgrade script for username limit settings Signed-off-by: Bill Erickson 2011-09-26 Thomas Berezansky * Open-ILS/src/sql/Pg/upgrade/XXXX.temp.sql: Unwrapped, badly named upgrade script Signed-off-by: Thomas Berezansky Signed-off-by: Bill Erickson 2011-09-24 Thomas Berezansky * Open-ILS/src/templates/opac/myopac/update_username.tt2, Open-ILS/web/opac/locale/en-US/opac.dtd: Wording change on username error Add that they may be restricted by policy. Signed-off-by: Thomas Berezansky Signed-off-by: Bill Erickson 2011-09-24 Thomas Berezansky * Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm, Open-ILS/src/sql/Pg/950.data.seed-values.sql, Open-ILS/src/templates/opac/myopac/prefs.tt2, Open-ILS/web/opac/skin/default/js/myopac.js: Username Change Limits Default is "Only allowed to change username if it looks like a barcode". There is a "Lock Username Changes" option to disallow username changing via the OPAC entirely, useful if syncing usernames to an outside source. There is also a username change limit disabling option that, if enabled and the Lock option is disabled, allows the previous behaviour of unlimited username changes. Signed-off-by: Thomas Berezansky Signed-off-by: Bill Erickson 2011-09-24 Thomas Berezansky * Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm, Open-ILS/src/sql/Pg/950.data.seed-values.sql, Open-ILS/src/templates/opac/myopac/update_username.tt2, Open-ILS/web/js/ui/default/actor/user/register.js, Open-ILS/web/opac/skin/default/js/myopac.js: Username Rules In TPac, enforce the "username can't look like a barcode" rule. Add new setting for username validation. If set, usernames must match. Add patron registration checks for usernames: No spaces If set, can look like a barcode (initial/no username picked) If set, can look like a username If both set, must look like one of them Signed-off-by: Thomas Berezansky Signed-off-by: Bill Erickson 2011-09-24 Thomas Berezansky * Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm, Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm, Open-ILS/src/templates/opac/myopac/update_email.tt2, Open-ILS/src/templates/opac/myopac/update_username.tt2, Open-ILS/web/opac/skin/default/js/myopac.js, Open-ILS/web/opac/skin/default/xml/myopac/myopac_summary.xml: Require password to change email/username Alter backend to check password period, not just for password changes. Add form elements for asking for current password to JSPac and TPac. Add handling for said form elements where needed. Add handling for "incorrect password" events in TPac. Signed-off-by: Thomas Berezansky Signed-off-by: Bill Erickson 2011-09-24 Thomas Berezansky * Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm: TPac: Default Password Strength Rule Every other password interface seems to have it. Implemented as a single regex in this case. Signed-off-by: Thomas Berezansky Signed-off-by: Bill Erickson 2011-09-12 Thomas Berezansky * Open-ILS/xul/staff_client/chrome/content/auth/session.js: When workstation is invalid request a new seed The original one may no longer be valid Signed-off-by: Thomas Berezansky Signed-off-by: Bill Erickson 2011-09-01 Thomas Berezansky * Open-ILS/examples/opensrf.xml.example, Open-ILS/src/c-apps/oils_auth.c: Make more auth values configurable Amount of time seed is valid Amount of time to keep failure count in memcache since last auth event Number of failures before locking out auth attempts Also, remove seed from memcache once it has been used once. Signed-off-by: Thomas Berezansky Signed-off-by: Bill Erickson 2011-08-30 Thomas Berezansky * Open-ILS/src/c-apps/oils_auth.c: Brute Force protection for authentication Count auth failures in memcache. If 10+ have occurred cause failure. After 90 seconds of no activity counter resets. Signed-off-by: Thomas Berezansky Signed-off-by: Bill Erickson 2011-09-30 Lebbeous Fogle-Weekley * Open-ILS/examples/fm_IDL.xml: link asset.copy_template.status to config.copy_status in the IDL If nothing else, this provides a dropdown for status in the copy template editor (the one for Serials, under the admin menus, not the one on the copy editing interface). Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Dan Wells 2011-10-04 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql: Make sure baseline schema is up to date Signed-off-by: Mike Rylander 2011-10-03 Dan Scott * build/tools/update_db.sh: Fix update_db.sh to set eg_version correctly psql wants --set=VARNAME=VALUE, we had -set VARNAME=VALUE; tested this fix and it works with PostgreSQL 9.0. Signed-off-by: Dan Scott 2011-10-03 Dan Scott * Open-ILS/src/templates/opac/parts/searchbar.tt2: TPAC: Fix searchbar typo by closing div Nesting of divs was thrown off, resulting in the footer appearing in the wrong place in search results / record display / etc, with the result that the footer inherited the 974px width instead of full 100% width. Signed-off-by: Dan Scott 2011-10-03 Dan Scott * Open-ILS/src/sql/Pg/upgrade/0631.schema.located_uri_visiblity_fix.s ql, Open-ILS/src/sql/Pg/upgrade/XXXX.schema.located_uri_visiblity_fix.s ql: LP865817: Fix Located URI visibility test Wrapped upgrade script for LP865817. Signed-off-by: Dan Scott 2011-10-03 Mike Rylander * Open-ILS/src/sql/Pg/300.schema.staged_search.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.schema.located_uri_visiblity_fix.s ql: Correct Located URI visiblity Located URIs should be visible when they exist at the search context org unit or an ancestor thereof. However, before the change embodied in this commit, they effectively acted exactly like copies, making records visible anywhere within the context+depth range. An example, using the stock example OU hierarchy: * Before this change, a Located URI with an owner of BR1 would cause its record to show up in a search at (or scoped to via a depth parameter) BR1, SYS1 or CONS. * Before this change, a Located URI with an owner of SYS1 would NOT cause its record to show up in a search at (or scoped to via a depth parameter) BR1! * After this change, a Located URI with an owner of BR1 will cause its record to show up only in a search with a context OU of BR1, irrespective of depth scoping. * After this change, a Located URI with an owner of SYS1 WILL cause its record to show up in a search with a context OU of BR1 or SYS1, regardless of depth scoping. Signed-off-by: Mike Rylander Signed-off-by: Dan Scott 2011-10-03 Dan Scott * Open-ILS/web/css/skin/default/opac/style.css: TPAC: No need for a 26px padding on the header bottom 26px on the bottom of the header was giving a bit too much space to the header. Signed-off-by: Dan Scott Signed-off-by: Bill Erickson 2011-10-03 Dan Scott * Open-ILS/src/templates/opac/parts/topnav.tt2, Open-ILS/web/css/skin/default/opac/style.css: TPAC: Replace dashboard images with CSS Also gets rid of a number of tables and a bunch of CSS definitions with hard-coded widths that will cause trouble when longer translated terms get dropped into place. Signed-off-by: Dan Scott Signed-off-by: Bill Erickson 2011-10-03 Bill Erickson * Open-ILS/src/templates/opac/parts/result/facets.tt2: Tpac: expand facet display fix When only one facet is collapsed, make sure we can expand it. Signed-off-by: Bill Erickson Signed-off-by: Dan Scott 2011-09-30 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Search.pm, Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Util.pm, Open-ILS/src/templates/opac/parts/result/facets.tt2, Open-ILS/src/templates/opac/parts/result/table.tt2, Open-ILS/web/css/skin/default/opac/style.css: TPac: Facets on results page Show search facets along the left side of the results page. Clicking on a facet re-runs the current search with the new facet appeneded. Selected facets are styled to indicate they are selected. Clicking on a selected facet removes that facet from the set of selected facets (i.e. it backs out the facet). TODO: update CSS to match default Evergreen skin Signed-off-by: Bill Erickson Signed-off-by: Dan Scott 2011-10-03 Lebbeous Fogle-Weekley * Open-ILS/web/opac/common/js/org_utils.js, Open-ILS/web/opac/skin/default/js/rdetail.js: JSPAC: Fix a bug (I think) in orgIsMine(), and show more MFHD holdings ... ... when search scope would have it so. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Dan Scott 2011-10-03 Michael Peters * Open-ILS/web/css/skin/default/opac/style.css: Tweak the tab shape in TT OPAC A slight modification to the "tab" elements throughout the OPAC to make them look more like tabs on a file folder. I found the rounded off bottoms less attractive, so I flattened them out to flow more evenly with the rest of the page. Signed-off-by: Michael Peters Signed-off-by: Lebbeous Fogle-Weekley 2011-10-03 Michael Peters * Open-ILS/src/templates/opac/parts/footer.tt2, Open-ILS/src/templates/opac/parts/homesearch.tt2, Open-ILS/src/templates/opac/parts/topnav_logo.tt2: Have TTPac utilize gradient friendly, transparent PNG files for the Evergreen logo Signed-off-by: Michael Peters Signed-off-by: Lebbeous Fogle-Weekley 2011-10-02 Dan Scott * Open-ILS/src/templates/opac/parts/footer.tt2, Open-ILS/src/templates/opac/parts/topnav.tt2, Open-ILS/web/css/skin/default/opac/style.css: TPAC: Simple CSS gradients for the header/footer Firefox, Safari, Chrome, Opera, and the Android browser support gradients. Use them. iOS 5 will support gradients. IE does not, naturally, but support is promised for IE 10. Including better IE support. Signed-off-by: Dan Scott Signed-off-by: Lebbeous Fogle-Weekley 2011-09-20 Dan Scott * Open-ILS/src/templates/opac/advanced.tt2, Open-ILS/src/templates/opac/cnbrowse.tt2, Open-ILS/src/templates/opac/home.tt2, Open-ILS/src/templates/opac/login.tt2, Open-ILS/src/templates/opac/mylist.tt2, Open-ILS/src/templates/opac/parts/myopac/base.tt2, Open-ILS/src/templates/opac/place_hold.tt2, Open-ILS/src/templates/opac/record.tt2, Open-ILS/src/templates/opac/results.tt2: TPAC: Remove the printnav bar from all screens Signed-off-by: Dan Scott Signed-off-by: Thomas Berezansky 2011-09-20 Dan Scott * Open-ILS/src/templates/opac/parts/searchbar.tt2, Open-ILS/web/css/skin/default/opac/style.css: Revamp the search bar to a narrative, single-line style Signed-off-by: Dan Scott Signed-off-by: Thomas Berezansky 2011-09-19 Dan Scott * Open-ILS/src/templates/opac/parts/record/summary.tt2: Add the remaining extras back to the record details Signed-off-by: Dan Scott Signed-off-by: Thomas Berezansky 2011-09-19 Dan Scott * Open-ILS/src/templates/opac/parts/record/authors.tt2, Open-ILS/src/templates/opac/parts/record/series.tt2, Open-ILS/src/templates/opac/parts/record/summary.tt2: TPAC: and then there were series Also, tighten up spacing considerably. Signed-off-by: Dan Scott Signed-off-by: Thomas Berezansky 2011-09-19 Dan Scott * Open-ILS/src/templates/opac/parts/record/summary.tt2, Open-ILS/web/css/skin/default/opac/style.css: Move the copies up higher Signed-off-by: Dan Scott Signed-off-by: Thomas Berezansky 2011-09-19 Dan Scott * Open-ILS/src/templates/opac/parts/record/authors.tt2, Open-ILS/src/templates/opac/parts/record/extras.tt2, Open-ILS/src/templates/opac/parts/record/summary.tt2, Open-ILS/web/css/skin/default/opac/style.css: Remove "Expand all extras" as there are fewer extras to expand Cleaner. Signed-off-by: Dan Scott Signed-off-by: Thomas Berezansky 2011-09-19 Dan Scott * Open-ILS/src/templates/opac/parts/record/authors.tt2, Open-ILS/src/templates/opac/parts/record/body.tt2, Open-ILS/src/templates/opac/parts/record/extras.tt2, Open-ILS/src/templates/opac/parts/record/subjects.tt2, Open-ILS/src/templates/opac/parts/record/summary.tt2, Open-ILS/web/css/skin/default/opac/style.css: Going for the Jungle skin feel (like Amazon) Signed-off-by: Dan Scott Signed-off-by: Thomas Berezansky 2011-09-30 Bill Erickson * Open-ILS/src/templates/opac/parts/advanced/global_row.tt2, Open-ILS/src/templates/opac/parts/searchbar.tt2: TPac: propagate searches to advanced search page The link that takes users to the advanced searc page now propagates any existing (well, all) search URL params. The change required some minor augmentation to the code that builds the advanced search form. Signed-off-by: Bill Erickson Signed-off-by: Lebbeous Fogle-Weekley 2011-09-29 Dan Scott * Open-ILS/web/opac/skin/default/js/rdetail.js: LP740320: Make submit the new bookbag dialog For the keyboard jockeys out there - if the enter key doesn't submit, the UI reviewer will not commit. Signed-off-by: Dan Scott 2011-08-26 James Fournie * Open-ILS/web/opac/skin/default/xml/page_rdetail.xml: Initial dialog isn't quite wide enough, here's a hackish way to fix it Signed-off-by: James Fournie Signed-off-by: Dan Scott 2011-08-26 James Fournie * Open-ILS/web/opac/skin/default/xml/page_rdetail.xml: Should probably use a more common button rather than the one for the advanced search Signed-off-by: James Fournie Signed-off-by: Dan Scott 2011-08-26 James Fournie * Open-ILS/web/opac/skin/default/js/rdetail.js: This makes more sense as an alert; the Dojo dialog has no button which is not user-friendly. Signed-off-by: James Fournie Signed-off-by: Dan Scott 2011-08-02 Mike Rylander * Open-ILS/web/opac/skin/default/js/rdetail.js, Open-ILS/web/opac/skin/default/xml/page_rdetail.xml: Markup-based dijit.Dialog implementation, inspired by and based on a patch from Joseph Lewis in https://bugs.launchpad.net/evergreen/+bug/787162 Signed-off-by: Mike Rylander Signed-off-by: Dan Scott 2011-09-29 Dan Scott * build/i18n/po/AutoFieldWidget.js/en-GB.po, build/i18n/po/TranslatorPopup.js/en-GB.po, build/i18n/po/User.js/en-GB.po, build/i18n/po/XULTermLoader.js/en-GB.po, build/i18n/po/acq.js/en-GB.po, build/i18n/po/admin.properties/en-GB.po, build/i18n/po/auth.properties/en-GB.po, build/i18n/po/capture.js/en-GB.po, build/i18n/po/cat.properties/en-GB.po, build/i18n/po/circ.properties/en-GB.po, build/i18n/po/common.properties/en-GB.po, build/i18n/po/conify.dtd/en-GB.po, build/i18n/po/conify.js/en-GB.po, build/i18n/po/db.seed/en-GB.po, build/i18n/po/fm_IDL.dtd/en-GB.po, build/i18n/po/ils_events.xml/en-GB.po, build/i18n/po/lang.dtd/en-GB.po, build/i18n/po/multiclass_search_help.html/en-GB.po, build/i18n/po/offline.properties/en-GB.po, build/i18n/po/opac.dtd/en-GB.po, build/i18n/po/opac.js/en-GB.po, build/i18n/po/patron.properties/en-GB.po, build/i18n/po/pickup_and_return.js/en-GB.po, build/i18n/po/pull_list.js/en-GB.po, build/i18n/po/register.js/en-GB.po, build/i18n/po/reports.dtd/en-GB.po, build/i18n/po/reports.js/en-GB.po, build/i18n/po/reservation.js/en-GB.po, build/i18n/po/selfcheck.js/en-GB.po, build/i18n/po/vandelay.dtd/en-GB.po: i18n: Merge en-GB translation from Launchpad Signed-off-by: Dan Scott 2011-09-29 Dan Scott * build/i18n/po/AutoFieldWidget.js/en-CA.po, build/i18n/po/TranslatorPopup.js/en-CA.po, build/i18n/po/User.js/en-CA.po, build/i18n/po/XULTermLoader.js/en-CA.po, build/i18n/po/acq.js/en-CA.po, build/i18n/po/admin.properties/en-CA.po, build/i18n/po/auth.properties/en-CA.po, build/i18n/po/capture.js/en-CA.po, build/i18n/po/cat.properties/en-CA.po, build/i18n/po/circ.properties/en-CA.po, build/i18n/po/common.properties/en-CA.po, build/i18n/po/conify.dtd/en-CA.po, build/i18n/po/conify.js/en-CA.po, build/i18n/po/db.seed/en-CA.po, build/i18n/po/fm_IDL.dtd/en-CA.po, build/i18n/po/ils_events.xml/en-CA.po, build/i18n/po/lang.dtd/en-CA.po, build/i18n/po/multiclass_search_help.html/en-CA.po, build/i18n/po/offline.properties/en-CA.po, build/i18n/po/opac.dtd/en-CA.po, build/i18n/po/opac.js/en-CA.po, build/i18n/po/patron.properties/en-CA.po, build/i18n/po/pickup_and_return.js/en-CA.po, build/i18n/po/pull_list.js/en-CA.po, build/i18n/po/register.js/en-CA.po, build/i18n/po/reports.dtd/en-CA.po, build/i18n/po/reports.js/en-CA.po, build/i18n/po/reservation.js/en-CA.po, build/i18n/po/selfcheck.js/en-CA.po, build/i18n/po/vandelay.dtd/en-CA.po: i18n: Merge en-CA translation from Launchpad Signed-off-by: Dan Scott 2011-09-29 Dan Scott * build/i18n/po/AutoFieldWidget.js/pt-BR.po, build/i18n/po/TranslatorPopup.js/pt-BR.po, build/i18n/po/User.js/pt-BR.po, build/i18n/po/XULTermLoader.js/pt-BR.po, build/i18n/po/acq.js/pt-BR.po, build/i18n/po/admin.properties/pt-BR.po, build/i18n/po/auth.properties/pt-BR.po, build/i18n/po/capture.js/pt-BR.po, build/i18n/po/cat.properties/pt-BR.po, build/i18n/po/circ.properties/pt-BR.po, build/i18n/po/common.properties/pt-BR.po, build/i18n/po/conify.dtd/pt-BR.po, build/i18n/po/conify.js/pt-BR.po, build/i18n/po/db.seed/pt-BR.po, build/i18n/po/fm_IDL.dtd/pt-BR.po, build/i18n/po/ils_events.xml/pt-BR.po, build/i18n/po/lang.dtd/pt-BR.po, build/i18n/po/multiclass_search_help.html/pt-BR.po, build/i18n/po/offline.properties/pt-BR.po, build/i18n/po/opac.dtd/pt-BR.po, build/i18n/po/opac.js/pt-BR.po, build/i18n/po/patron.properties/pt-BR.po, build/i18n/po/pickup_and_return.js/pt-BR.po, build/i18n/po/pull_list.js/pt-BR.po, build/i18n/po/register.js/pt-BR.po, build/i18n/po/reports.dtd/pt-BR.po, build/i18n/po/reports.js/pt-BR.po, build/i18n/po/reservation.js/pt-BR.po, build/i18n/po/selfcheck.js/pt-BR.po, build/i18n/po/vandelay.dtd/pt-BR.po: i18n: Merge pt-BR translation from Launchpad Signed-off-by: Dan Scott 2011-09-29 Dan Scott * build/i18n/po/AutoFieldWidget.js/ru-RU.po, build/i18n/po/TranslatorPopup.js/ru-RU.po, build/i18n/po/User.js/ru-RU.po, build/i18n/po/XULTermLoader.js/ru-RU.po, build/i18n/po/acq.js/ru-RU.po, build/i18n/po/admin.properties/ru-RU.po, build/i18n/po/auth.properties/ru-RU.po, build/i18n/po/capture.js/ru-RU.po, build/i18n/po/cat.properties/ru-RU.po, build/i18n/po/circ.properties/ru-RU.po, build/i18n/po/common.properties/ru-RU.po, build/i18n/po/conify.dtd/ru-RU.po, build/i18n/po/conify.js/ru-RU.po, build/i18n/po/db.seed/ru-RU.po, build/i18n/po/fm_IDL.dtd/ru-RU.po, build/i18n/po/ils_events.xml/ru-RU.po, build/i18n/po/lang.dtd/ru-RU.po, build/i18n/po/multiclass_search_help.html/ru-RU.po, build/i18n/po/offline.properties/ru-RU.po, build/i18n/po/opac.dtd/ru-RU.po, build/i18n/po/opac.js/ru-RU.po, build/i18n/po/patron.properties/ru-RU.po, build/i18n/po/pickup_and_return.js/ru-RU.po, build/i18n/po/pull_list.js/ru-RU.po, build/i18n/po/register.js/ru-RU.po, build/i18n/po/reports.dtd/ru-RU.po, build/i18n/po/reports.js/ru-RU.po, build/i18n/po/reservation.js/ru-RU.po, build/i18n/po/selfcheck.js/ru-RU.po, build/i18n/po/vandelay.dtd/ru-RU.po: i18n: Merge ru-RU translation from Launchpad Signed-off-by: Dan Scott 2011-09-29 Dan Scott * build/i18n/po/AutoFieldWidget.js/hy-AM.po, build/i18n/po/TranslatorPopup.js/hy-AM.po, build/i18n/po/User.js/hy-AM.po, build/i18n/po/XULTermLoader.js/hy-AM.po, build/i18n/po/acq.js/hy-AM.po, build/i18n/po/admin.properties/hy-AM.po, build/i18n/po/auth.properties/hy-AM.po, build/i18n/po/capture.js/hy-AM.po, build/i18n/po/cat.properties/hy-AM.po, build/i18n/po/circ.properties/hy-AM.po, build/i18n/po/common.properties/hy-AM.po, build/i18n/po/conify.dtd/hy-AM.po, build/i18n/po/conify.js/hy-AM.po, build/i18n/po/db.seed/hy-AM.po, build/i18n/po/fm_IDL.dtd/hy-AM.po, build/i18n/po/ils_events.xml/hy-AM.po, build/i18n/po/lang.dtd/ar-AR.po, build/i18n/po/lang.dtd/hy-AM.po, build/i18n/po/multiclass_search_help.html/hy-AM.po, build/i18n/po/offline.properties/hy-AM.po, build/i18n/po/opac.dtd/hy-AM.po, build/i18n/po/opac.js/hy-AM.po, build/i18n/po/patron.properties/hy-AM.po, build/i18n/po/pickup_and_return.js/hy-AM.po, build/i18n/po/pull_list.js/hy-AM.po, build/i18n/po/register.js/hy-AM.po, build/i18n/po/reports.dtd/hy-AM.po, build/i18n/po/reports.js/hy-AM.po, build/i18n/po/reservation.js/hy-AM.po, build/i18n/po/selfcheck.js/hy-AM.po, build/i18n/po/vandelay.dtd/hy-AM.po: i18n: Merge Armenian (hy-AM) translation from Launchpad Signed-off-by: Dan Scott 2011-09-29 Dan Scott * build/i18n/po/AutoFieldWidget.js/cs-CZ.po, build/i18n/po/TranslatorPopup.js/cs-CZ.po, build/i18n/po/User.js/cs-CZ.po, build/i18n/po/XULTermLoader.js/cs-CZ.po, build/i18n/po/acq.js/cs-CZ.po, build/i18n/po/admin.properties/cs-CZ.po, build/i18n/po/auth.properties/cs-CZ.po, build/i18n/po/capture.js/cs-CZ.po, build/i18n/po/cat.properties/cs-CZ.po, build/i18n/po/circ.properties/cs-CZ.po, build/i18n/po/common.properties/cs-CZ.po, build/i18n/po/conify.dtd/cs-CZ.po, build/i18n/po/conify.js/cs-CZ.po, build/i18n/po/db.seed/cs-CZ.po, build/i18n/po/fm_IDL.dtd/cs-CZ.po, build/i18n/po/ils_events.xml/cs-CZ.po, build/i18n/po/lang.dtd/cs-CZ.po, build/i18n/po/multiclass_search_help.html/cs-CZ.po, build/i18n/po/offline.properties/cs-CZ.po, build/i18n/po/opac.dtd/cs-CZ.po, build/i18n/po/opac.js/cs-CZ.po, build/i18n/po/patron.properties/cs-CZ.po, build/i18n/po/pickup_and_return.js/cs-CZ.po, build/i18n/po/pull_list.js/cs-CZ.po, build/i18n/po/register.js/cs-CZ.po, build/i18n/po/reports.dtd/cs-CZ.po, build/i18n/po/reports.js/cs-CZ.po, build/i18n/po/reservation.js/cs-CZ.po, build/i18n/po/selfcheck.js/cs-CZ.po, build/i18n/po/vandelay.dtd/cs-CZ.po: i18n: Merge cs-CZ translation from Launchpad Signed-off-by: Dan Scott 2011-09-29 Dan Scott * build/i18n/po/AutoFieldWidget.js/es-ES.po, build/i18n/po/TranslatorPopup.js/es-ES.po, build/i18n/po/User.js/es-ES.po, build/i18n/po/XULTermLoader.js/es-ES.po, build/i18n/po/acq.js/es-ES.po, build/i18n/po/admin.properties/es-ES.po, build/i18n/po/auth.properties/es-ES.po, build/i18n/po/capture.js/es-ES.po, build/i18n/po/cat.properties/es-ES.po, build/i18n/po/circ.properties/es-ES.po, build/i18n/po/common.properties/es-ES.po, build/i18n/po/conify.dtd/es-ES.po, build/i18n/po/conify.js/es-ES.po, build/i18n/po/db.seed/es-ES.po, build/i18n/po/fm_IDL.dtd/es-ES.po, build/i18n/po/ils_events.xml/es-ES.po, build/i18n/po/lang.dtd/es-ES.po, build/i18n/po/multiclass_search_help.html/es-ES.po, build/i18n/po/offline.properties/es-ES.po, build/i18n/po/opac.dtd/es-ES.po, build/i18n/po/opac.js/es-ES.po, build/i18n/po/patron.properties/es-ES.po, build/i18n/po/pickup_and_return.js/es-ES.po, build/i18n/po/pull_list.js/es-ES.po, build/i18n/po/register.js/es-ES.po, build/i18n/po/reports.dtd/es-ES.po, build/i18n/po/reports.js/es-ES.po, build/i18n/po/reservation.js/es-ES.po, build/i18n/po/selfcheck.js/es-ES.po, build/i18n/po/vandelay.dtd/es-ES.po: i18n: Merge es-ES translation from Launchpad Signed-off-by: Dan Scott 2011-09-29 Dan Scott * build/i18n/po/AutoFieldWidget.js/fr-CA.po, build/i18n/po/TranslatorPopup.js/fr-CA.po, build/i18n/po/User.js/fr-CA.po, build/i18n/po/XULTermLoader.js/fr-CA.po, build/i18n/po/acq.js/fr-CA.po, build/i18n/po/admin.properties/fr-CA.po, build/i18n/po/auth.properties/fr-CA.po, build/i18n/po/capture.js/fr-CA.po, build/i18n/po/cat.properties/fr-CA.po, build/i18n/po/circ.properties/fr-CA.po, build/i18n/po/common.properties/fr-CA.po, build/i18n/po/conify.dtd/fr-CA.po, build/i18n/po/conify.js/fr-CA.po, build/i18n/po/db.seed/fr-CA.po, build/i18n/po/fm_IDL.dtd/fr-CA.po, build/i18n/po/ils_events.xml/fr-CA.po, build/i18n/po/lang.dtd/fr-CA.po, build/i18n/po/multiclass_search_help.html/fr-CA.po, build/i18n/po/offline.properties/fr-CA.po, build/i18n/po/opac.dtd/fr-CA.po, build/i18n/po/opac.js/fr-CA.po, build/i18n/po/patron.properties/fr-CA.po, build/i18n/po/pickup_and_return.js/fr-CA.po, build/i18n/po/pull_list.js/fr-CA.po, build/i18n/po/register.js/fr-CA.po, build/i18n/po/reports.dtd/fr-CA.po, build/i18n/po/reports.js/fr-CA.po, build/i18n/po/reservation.js/fr-CA.po, build/i18n/po/selfcheck.js/fr-CA.po, build/i18n/po/vandelay.dtd/fr-CA.po: i18n: Merge fr-CA translation from Launchpad Signed-off-by: Dan Scott 2011-09-16 Liam Whalen * Open-ILS/xul/staff_client/server/cat/spine_labels.js: Modified spine_labels.js to retain UTF-8 encoding Dan Wells posted a fix to the DEV list for receipt printing that allowed the receipt printer to print UTF-8 characters. I used the ideas in that fix to modify spine_labels.js. In spine_labels.js, the url passed to the preview in preview_xul_192 was encoding the url with the javascript encode() function. This function does not preserve UTF-8 encodings. I changed the function to encodeURIComponent, and UTF-8 characters are now displayed properly by the spine label printer code. Signed-off-by: Liam Whalen Signed-off-by: Dan Scott 2011-09-29 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/Application/Cat/AssetCommon.pm: Added missing Penalty module import for AssetCommon The lack of import primarily affected the Action/Trigger MarkItemLost reactor, which does not already import OpenILS::Utils::Penalty directly or indirectly. Signed-off-by: Bill Erickson 2011-09-28 Dan Scott * Open-ILS/examples/apache/eg.conf, README: Remove an installation step: Listen 443 uncommenting Every distribution known to man ships Apache listening on port 443, so installers always have to comment out the "Listen 443" directive - so why not just comment it out ourselves and save a step in the installation instructions? Signed-off-by: Dan Scott 2011-09-28 Bill Erickson * Open-ILS/src/templates/opac/parts/base.tt2, Open-ILS/src/templates/opac/parts/goog_analytics.tt2, Open-ILS/src/templates/opac/parts/js.tt2: TPac: move google analytics import to head Google Analytics documention recommends loading the JS in the page . http://www.google.com/support/googleanalytics/bin/answer.py?answer=174090Use as directed by default. Also, moved the JS loading chunk to its own template to ease override by those who do not wish to use as directed. Signed-off-by: Bill Erickson Signed-off-by: Lebbeous Fogle-Weekley 2011-09-28 Michael Peters * Open-ILS/src/templates/conify/global/acq/edi_account.tt2: A slight modification to prevent clipping in the EDI Accounts interface Just a few tweaks via CSS to make sure the footer notes don't clip off part of the main grid. Signed-off-by: Michael Peters Signed-off-by: Mike Rylander 2011-09-28 Mike Rylander * Open-ILS/src/reporter/clark-kent.pl: Provide proper hrefs for links back from report debugging pages Reimplementation of a fix provided by Michael Peters. The originally submitted patch included several fixes provided by an unrelated patch, and a regression in build-time embedded tokens. Original branch at: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mrpeters-isl/clark_kent_back_linksSigned-off-by: Mike Rylander 2011-09-22 Dan Scott * Open-ILS/src/reporter/clark-kent.pl: LP856567: Mark HTML report output as Unicode-encoded Non-ASCII characters in report ouput that has been generated in HTML format appears to be corrupted when viewed in a browser. This can be manually corrected by switching the "Encoding" browser option, but it would be better to include in the output HTML to tell the browser directly. Signed-off-by: Dan Scott Signed-off-by: Mike Rylander 2011-09-27 Dan Wells * Open-ILS/src/perlmods/lib/OpenILS/Utils/MFHD.pm, Open-ILS/src/perlmods/lib/OpenILS/Utils/MFHD/Caption.pm: MFHD compression fails with pattern-less captions The current code assumes that if you try to compress a range of MFHD holdings, you actually have the necessary pattern information. This commit introduces a very basic check to avoid the most common failure case. Signed-off-by: Dan Wells Signed-off-by: Mike Rylander 2011-09-27 Mike Rylander * build/tools/update_db.sh: Teach update_db.sh to find the currently installed version number via eg_config and supply that when applying updates Signed-off-by: Mike Rylander Signed-off-by: Bill Erickson 2011-09-27 Bill Erickson * Open-ILS/src/support-scripts/marc_stream_importer.pl: Read STDIN up to record separator then stop The initial (and only known) target for the importer is OCLC Connexion exports, which export 1 record at a time, with each record ending with the standard record separator. There is no end-of-file / end-of-transmission indicator, so the while() loop always blocks and fails on the timeout alarm after the first record is read. Until a more flexible solution is in place, roll back support for reading multiple records via STDIN. The original commit was 679506975f0efb6e2f6f17b0c19e3c53c5bfda44 Note, the feature being rolled back was not actually necessary to implement the feature in the commit (file-based imports). It was just an added bonus. Signed-off-by: Bill Erickson 2011-09-23 Dan Scott * Open-ILS/xul/staff_client/server/cat/volume_copy_creator.js: LP857460: Get the generic class scheme when adding vols In a default Evergreen instance, in the "Add Volumes" interface for a bib record with both LC and Dewey call numbers, the list of call numbers from which you can select appears to be limited to Dewey, even though the "Bib Call #" field is populated with an LC call number. The problem is that here we're grabbing the first entry from the asset.call_number_classification table, and you might expect that to be the "Generic" entry - however, it turns out to be the "Dewey" entry because the entries are ordered alphabetically by .name(), not by database ID. (You can test this be changing the name of "Dewey" to "Vicious" and see that the "Generic" entry is chosen instead). This commit changes the process to first search the acnc array for a name() = "Generic"; and then if we don't find that, fall back to the first entry in the classification scheme. Signed-off-by: Dan Scott Signed-off-by: Dan Wells 2011-09-26 Bill Erickson * Open-ILS/examples/apache/eg_vhost.conf: Removed old vandelay config from sample apache config Bye, bye xmlent Signed-off-by: Bill Erickson 2011-09-26 Thomas Berezansky * Open-ILS/src/templates/opac/parts/org_selector.tt2: TPac: Respect OU opac_visible flags Unless we appear to be in staff mode. Then continue to ignore them. Signed-off-by: Thomas Berezansky Signed-off-by: Dan Scott 2011-09-24 Thomas Berezansky * Open-ILS/src/templates/opac/myopac/update_email.tt2, Open-ILS/src/templates/opac/myopac/update_username.tt2: TPac: Fix bolding of bad email/username HTML filter the variable, not the entire language string. Signed-off-by: Thomas Berezansky Signed-off-by: Dan Scott 2011-09-24 Thomas Berezansky * Open-ILS/src/templates/opac/myopac/main.tt2, Open-ILS/src/templates/opac/parts/myopac/main_base.tt2: TPac: Hide CC Payment info when not enabled Signed-off-by: Thomas Berezansky Signed-off-by: Dan Scott 2011-09-24 Thomas Berezansky * Open-ILS/src/templates/opac/parts/myopac/main_base.tt2: TPac Fixes - Missing Quotes Start off real easy, add some missing quotes. Signed-off-by: Thomas Berezansky Signed-off-by: Dan Scott 2011-09-26 Dan Wells * : commit 6d7ed210b38701d6ce7aa48c866f7d67ad5dcb8e Author: Dan Wells Date: Mon Sep 26 14:23:31 2011 -0400 2011-09-14 Jeff Godin * .mailmap: Create git .mailmap file for Evergreen This is an initial .mailmap file for Evergreen. The .mailmap file is used by git-shortlog to "coalesce together commits by the same person". In the output of git-shortlog, this eliminates duplicate entries such as the username@UUID entries from the svn to git migration. Compare "git shortlog -nes" with and without this .mailmap Signed-off-by: Jeff Godin Signed-off-by: Dan Scott 2011-09-23 Thomas Berezansky * Open-ILS/src/sql/Pg/upgrade/XXXX.suppress_transits.sql: Unwrapped Suppress Transits upgrade script Signed-off-by: Thomas Berezansky Signed-off-by: Dan Wells 2011-09-13 Thomas Berezansky * Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm, Open-ILS/src/sql/Pg/950.data.seed-values.sql: Suppress Transits Add two new OU settings: circ.transit.suppress_hold circ.transit.suppress_non_hold If a transit would be generated between the current library and another and the appropriate setting is set for both end with the same value the transit will be suppressed. If either end is set to an empty string then transit suppression will be disabled, even if both ends are set to an empty string. In addition, transits from other locations will be received when their destination shares suppression with the current library. circ.transit.suppress_hold will cause holds to go to the hold shelf instead of into transit when in effect. Non-hold transits should not check it. This should be useful when multiple parts of a library share a hold shelf, but are split on the org tree. circ.transit.suppress_non_hold will cause items to reshelve instead of going into transit. Hold transits should not check it. This should be useful when multiple parts of a library are in the same building and have no need to transit items before reshelving/cataloging. In order to suppress *all* transits both settings need to be set. Signed-off-by: Thomas Berezansky Signed-off-by: Dan Wells 2011-09-26 Dan Scott * Open-ILS/src/templates/opac/parts/js.tt2: TPAC: Fix for staff UI with multiple MFHD records XUL's JavaScript doesn't mind trailing commas on an array, but really doesn't like an array in which the elements aren't separated by commas :) Signed-off-by: Dan Scott 2011-09-26 Bill Erickson * Open-ILS/src/templates/opac/parts/js.tt2, Open-ILS/web/js/ui/default/opac/staff.js: TPac: MFHD staff client actions integration Populdate the necessary window.mfhdDetails data for the staff client and fire the mfhdDrawn event Signed-off-by: Bill Erickson Signed-off-by: Dan Scott 2011-09-26 Mike Rylander * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/upgrade/0629.data.jedi-template.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.data.jedi-template.sql: Stamping upgrade script for EDI cleanup Signed-off-by: Mike Rylander 2011-09-19 Lebbeous Fogle-Weekley * Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Reactor.pm, Open-ILS/src/sql/Pg/950.data.seed-values.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.data.jedi-template.sql, Open-ILS/src/support-scripts/edi_pusher.pl: Some EDI translation fixes for troublesome input characters This attempts to address enough of the issues in https://bugs.launchpad.net/evergreen/+bug/812593 to move forward. When the ? character appears in lineitem attributes for a PO that we send off for EDI translation, the translator fails if that ? is the last character of the string. This commit avoids that situation. This commit also removes any Unicode characters from the JEDI (the input to the translator process), as they're not going to make it to the EDIFACT output anyhow, and will just confound the translator. This commit also pre-escapes quotation marks in lineitem attributes so that we don't produce invalid JSON for our JEDI. This commit also destroys the death star. Seriously, the right way to fix some of the issues people have had is for somebody to learn Ruby and to address them either in edi_webrick.rb, in edi4r, or in openils-mapper (wherever the issues may be). Working on that. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Mike Rylander 2011-09-14 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Record.pm, Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Search.pm, Open-ILS/src/templates/opac/parts/js.tt2, Open-ILS/src/templates/opac/parts/record/body.tt2, Open-ILS/src/templates/opac/parts/searchbar.tt2, Open-ILS/web/css/skin/default/opac/style.css, Open-ILS/web/js/ui/default/opac/staff.js: TPac: Page through search results on details page Consistent with jspac, when you land on a record details page and you got there from doing a search, let the user page through the search results directly on the record detail page. This also includes the necessary JS callbacks to support paging in the staff client. Signed-off-by: Bill Erickson Signed-off-by: Lebbeous Fogle-Weekley 2011-09-26 Jason Etheridge * Open-ILS/src/extras/Makefile.install: perl-parent prerequisite for RHEL. hope it's fine for centos :) Signed-off-by: Jason Etheridge 2011-09-18 Dan Scott * Open-ILS/src/templates/opac/parts/record/issues.tt2, Open-ILS/web/css/skin/default/opac/style.css: TPAC: Add some style to MFHD holdings summaries Simple grey background for the holdings summary header for each record; add a TBODY element to the holdings table for validity; offset the MFHD type by 1em to group entries under each holdings location. Signed-off-by: Dan Scott Signed-off-by: Bill Erickson 2011-09-18 Dan Scott * Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Serial.pm, Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Record.pm: TPAC: Give MFHD summaries OU / depth awareness Rather than returning all results and filtering on the client-side, as we're currently doing in the JSPAC, teach the open-ils.search.serial.record.bib.retrieve method to accept optional OU & OU depth arguments and do the filtering in the query; cuts down on network traffic and should be generally more efficient. Note that in the absence of an explicit "depth" CGI param, EGCatLoader/Record currently defaults to a depth of "0"; we could teach it to look up & cache the depth of the "loc" param for the sake of convenience & arguably more accuracy. Also note that the sub/dist serial approach probably needs to be taught similar method-side filtering, but I hope more knowledgeable brains will work out what should happen with ssub.holding_lib / sdist.owning_lib. Signed-off-by: Dan Scott Signed-off-by: Bill Erickson 2011-09-18 Dan Scott * Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Record.pm, Open-ILS/src/templates/opac/parts/record/extras.tt2, Open-ILS/src/templates/opac/parts/record/issues.tt2: TPAC: tentative MFHD display steps Retrieve and display MFHD records in the TPAC, piggybacking on the "Issues" twisty section. TODO: Take org_unit & depth into account when deciding which MFHD records to display. Right now we're just showing all of them. Signed-off-by: Dan Scott Signed-off-by: Bill Erickson 2011-09-25 Galen Charlton * Open-ILS/src/support-scripts/marc_stream_importer.pl: lp859190: make marc_stream_import always import non-matches Fixes regression of (implicit, undocumented) functionality introduced in commit da3a45344205. Current use case for the streaming MARC importer for OCLC Connexion exports assumes that non-matching records should always be added. Signed-off-by: Galen Charlton Signed-off-by: Bill Erickson 2011-09-23 Jason Etheridge * Open-ILS/xul/staff_client/chrome/content/OpenILS/data.js: silent macro updates Signed-off-by: Jason Etheridge 2011-09-23 Jason Etheridge * Open-ILS/xul/staff_client/chrome/content/OpenILS/data.js: we need %mbts_xact_start% for both the bills_current and bills_historical receipt templates Signed-off-by: Jason Etheridge 2011-09-20 Jeff Godin * Open-ILS/xul/staff_client/chrome/content/OpenILS/data.js, Open-ILS/xul/staff_client/server/circ/print_list_template_editor.js: Fix bills_current template to use mbts_id macro Fix bills_current template to use mbts_id macro instead of non-existant id macro. Also update sample data so that receipt preview displays correctly with respect to mbts_id macro. Fixes https://bugs.launchpad.net/evergreen/+bug/811175 Signed-off-by: Jeff Godin Signed-off-by: Jason Etheridge 2011-09-21 Jeff Godin * Open-ILS/web/opac/locale/en-US/lang.dtd, Open-ILS/xul/staff_client/server/patron/bill2.js, Open-ILS/xul/staff_client/server/patron/bill_history.js: Fix: Current Bills thinks it is Bill History This fixes LP 855894: Bills interface calls itself Bill History, uses bills_historical receipt template https://bugs.launchpad.net/evergreen/+bug/855894 At some point in development, the Current Bills and the Bill History interface were in a unified file, with an xul_param of "current" used to switch between the two. Nothing currently sets the xul_param "current", so the Current Bills interface (bill2.xul and bill2.js) was improperly: * not hiding the xact_finish column * using a caption label of "Bill History" * using the bills_historical receipt template The Bill History interface was okay -- "not current" was the default. This commit removes the tests for xul_param('current') and uses the appropriate code for each interface. // this code in both bill2.js and bill_history.js: var template = 'bills_historical'; if (xul_param('current')) template = 'bills_current'; // becomes: var template = 'bills_current'; // in bill2.js var template = 'bills_historical'; // in bill_history.js Also: added missing staff.patron.bill_interface.caption.label entity Signed-off-by: Jeff Godin Signed-off-by: Jason Etheridge 2011-09-20 Jeff Godin * Open-ILS/xul/staff_client/chrome/content/OpenILS/data.js, Open-ILS/xul/staff_client/chrome/content/main/constants.js, Open-ILS/xul/staff_client/server/main/data.xul, Open-ILS/xul/staff_client/server/patron/bill_cc_info.xul, Open-ILS/xul/staff_client/server/patron/bills.js, Open-ILS/xul/staff_client/server/patron/bills.xul, Open-ILS/xul/staff_client/server/patron/bills_overlay.xul: Remove the old bills interface. Remove the old bills interface and references to it. see https://bugs.launchpad.net/evergreen/+bug/854951 Also remove the XUL_PATRON_BILL_ALTERNATE_VIEW constant and the bills_main_view receipt template, as they were only referenced in bills.js. The bills_main_view template will still persist in existing workstation configurations until such time as we have code to remove unused templates. I made no effort to remove strings which may have only been used by the old bills interface. Signed-off-by: Jeff Godin Signed-off-by: Jason Etheridge 2011-09-22 Bill Erickson * Open-ILS/src/templates/opac/myopac/main.tt2: TPac: repair IE check-all action on transaction list IE does not respond to 'onchange' for checkboxes? Use onclick instead... Signed-off-by: Bill Erickson 2011-09-22 Bill Erickson * Open-ILS/src/sql/Pg/002.schema.config.sql, Open-ILS/src/sql/Pg/200.schema.acq.sql, Open-ILS/src/sql/Pg/upgrade/0628.schema.acq_fund_view_repairs.sql, Open-ILS/src/sql/Pg/upgrade/xxxx.schema.acq_lp800477: Stamped upgrade script for ACQ fund view repairs At the heart of this change is the need to force acq.fund_debit_total to return exactly 1 row per fund, instead of 1 per fund + encumbrance value. However, such a change required rearranging a number of dependent views. Also added acq.fund_spent_balance to the set of views that needs dropping and re-building. Minor SQL format change to match surrounding code in schema file See also https://bugs.launchpad.net/evergreen/+bug/800477 Signed-off-by: Bill Erickson 2011-09-19 James Fournie * Open-ILS/src/sql/Pg/200.schema.acq.sql, Open-ILS/src/sql/Pg/upgrade/xxxx.schema.acq_lp800477: Addresses LP#800477 where some acq views calculate the totals incorrectly or in unexpected ways. Signed-off-by: James Fournie Signed-off-by: Bill Erickson 2011-09-22 Jason Etheridge * Open-ILS/xul/staff_client/chrome/content/main/constants.js: The tpac should be SSL inside the staff client Signed-off-by: Jason Etheridge 2011-09-22 Jason Etheridge * : commit 6886c07f4ce333e9a0586ff373037137b9866991 Author: Jason Etheridge Date: Thu Sep 22 10:36:57 2011 -0400 2011-09-22 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm, Open-ILS/src/templates/opac/myopac/main_pay.tt2, Open-ILS/src/templates/opac/myopac/main_payment_form.tt2: TPac: credit card payment bug fixes / cleanup * Repaired bug with paying multiple transactions * Replaced JS-based back/cancel navigation with a's * Added some debug logging Signed-off-by: Bill Erickson 2011-09-22 Bill Erickson * Open-ILS/src/templates/opac/parts/header.tt2: Tpac: better param array detection in mkurl() Avoid propagating empty arrays as "ARRAY(JUNK)" Signed-off-by: Bill Erickson 2011-09-22 Dan Scott * Open-ILS/src/sql/Pg/950.data.seed-values.sql, Open-ILS/src/sql/Pg/upgrade/0627.data.patron-password-reset-msg.sql , Open-ILS/src/sql/Pg/upgrade/XXXX.data.patron-password-reset-msg.sql: Password resets: avoid run-on subjects The password reset template had a space on the first blank line after the Subject: which lead to the first paragraph being tacked onto the Subject line. Get rid of the space, and create an upgrade script ready to roll. Signed-off-by: Dan Scott 2011-09-20 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm, Open-ILS/src/templates/opac/password_reset.tt2, Open-ILS/web/css/skin/default/opac/style.css: TPac: password reset honors success/error style Signed-off-by: Bill Erickson Signed-off-by: Dan Scott 2011-09-19 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader.pm, Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm, Open-ILS/src/sql/Pg/950.data.seed-values.sql, Open-ILS/src/sql/Pg/upgrade/XXXX.data.patron-password-reset-msg.sql , Open-ILS/src/templates/opac/parts/login/form.tt2, Open-ILS/src/templates/opac/password_reset.tt2: TPac: integrated patron password reset Port the existing password reset functionality into TPac. This allows us to leverage the TPac innards for localization. It also means there's one less moving part. (and, incidentally, no more dojo for the form). Signed-off-by: Bill Erickson Signed-off-by: Dan Scott 2011-09-16 Bill Erickson * Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Biblio.pm, Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Search.pm: Tpac: longer timeout for marc "expert" search Since MARC searches can take a while, raise the default timeout from 1 minute to 2, with the option (at the API layer) of raising it to 5. Signed-off-by: Bill Erickson Signed-off-by: Dan Scott 2011-09-21 Thomas Berezansky * Open-ILS/web/opac/locale/en-US/lang.dtd, Open-ILS/xul/staff_client/server/index.xhtml: Add Toggle option to portal for TPac use In testing I didn't have to restart the staff client, but as constants.js is loaded pretty much everywhere I have no clue where the URL array may be stale. Signed-off-by: Thomas Berezansky Signed-off-by: Dan Scott 2011-09-21 Thomas Berezansky * Open-ILS/xul/staff_client/chrome/content/main/constants.js, Open-ILS/xul/staff_client/defaults/preferences/prefs.js: Create preference for opac used in staff client If enabled use the TPac. Otherwise JSPac. Signed-off-by: Thomas Berezansky Signed-off-by: Dan Scott 2011-09-21 Dan Scott * Open-ILS/web/css/skin/default/opac/style.css: TPAC: Make "Sort by" select box match style of search bar The "Sort by" select box in search results had a native widget style, compared to the search widget styles of the search bar. A simple CSS tweak makes it consistent. Signed-off-by: Dan Scott 2011-09-21 Dan Scott * Open-ILS/src/templates/opac/results.tt2, Open-ILS/web/css/skin/default/opac/style.css: Group "Sort by" and sort select box together The sort select box was weirdly way over on the right. Fix that. Also address slightly weird vertical alignment of some elements of the results header bar. Also use
Signed-off-by: Bill Erickson 2011-09-12 Bill Erickson * Open-ILS/src/templates/opac/parts/qtype_selector.tt2: TPac: Do not URI-escape index class/names in search dropdown id|bibcn, for example, through the |uri filter turns into "id%7Cbibcn" in the option value. Pipe through |html instead, just to be safe. Signed-off-by: Bill Erickson 2011-09-12 Bill Erickson * : Merge remote branch 'working/collab/berick/tpac-misc-cleanup' into template-toolkit-opac-master-merge 2011-09-12 Bill Erickson * : Merge remote branch 'working/user/dbs/lp801624_blow_away_postgresql' 2011-09-12 Bill Erickson * Open-ILS/examples/oils_web.xml.example, README: Removed sample oils_web.xml; removed from README Thanks for the suggestion, Dan. Signed-off-by: Bill Erickson 2011-09-12 Bill Erickson * Open-ILS/src/templates/base.tt2, Open-ILS/src/templates/vandelay/vandelay.tt2: Remove no-longer-necessary DTD override in vandelay Also, since vandelay was the only code using this hacked-in override option, remove the option from the base template. Signed-off-by: Bill Erickson 2011-09-12 Bill Erickson * Open-ILS/src/templates/vandelay/inc/attrs.tt2, Open-ILS/src/templates/vandelay/inc/export.tt2, Open-ILS/src/templates/vandelay/inc/import_errors.tt2, Open-ILS/src/templates/vandelay/inc/marchtml.tt2, Open-ILS/src/templates/vandelay/inc/matches.tt2, Open-ILS/src/templates/vandelay/inc/progress.tt2, Open-ILS/src/templates/vandelay/inc/queue.tt2, Open-ILS/src/templates/vandelay/inc/queueselect.tt2, Open-ILS/src/templates/vandelay/inc/toolbar.tt2, Open-ILS/src/templates/vandelay/inc/upload.tt2, Open-ILS/src/templates/vandelay/vandelay.tt2, Open-ILS/web/opac/locale/en-US/vandelay.dtd: Vandelay: import strings from DTD Using the new template-style embedded string localizer: [% l('...') %] Removed vandelay.dtd. Signed-off-by: Bill Erickson 2011-09-12 Bill Erickson * Open-ILS/web/js/ui/default/vandelay/vandelay.js: Vandelay: repaired URL path to embedded match set editor Signed-off-by: Bill Erickson 2011-09-11 Bill Erickson * Open-ILS/src/templates/acq/currency_type/list.tt2, Open-ILS/src/templates/acq/financial/list_currency_types.tt2, Open-ILS/src/templates/acq/financial/list_funding_sources.tt2, Open-ILS/src/templates/acq/financial/list_funds.tt2, Open-ILS/src/templates/acq/financial/view_fund.tt2, Open-ILS/src/templates/acq/financial/view_funding_source.tt2, Open-ILS/src/templates/acq/financial/view_provider.tt2, Open-ILS/src/templates/acq/fund/list.tt2, Open-ILS/src/templates/acq/fund/view.tt2, Open-ILS/src/templates/acq/funding_source/list.tt2, Open-ILS/src/templates/acq/funding_source/view.tt2: TPac: template path cleanup Rearrange the few templates that relied on the now-defunct oils_web.xml handler path/template mapping. Signed-off-by: Bill Erickson 2011-09-11 Bill Erickson * Open-ILS/examples/apache/eg_vhost.conf, Open-ILS/src/perlmods/lib/OpenILS/WWW/EGWeb.pm: TPac: deprecate oils_web.xml Configuration values are now loaded from Apache configuration. Signed-off-by: Bill Erickson 2011-09-11 Bill Erickson * Open-ILS/examples/oils_web.xml.example, Open-ILS/src/perlmods/lib/OpenILS/WWW/EGWeb.pm: TPac: locale handling improvements Allow Locale::Maketext to fall through to parent locales (superordinate) when the a translation for a string in the given locale is not present. Locale::Maketext suppports arbitrary-length locale tags, so it's possible to create locale hierarchies. For example, you could create branch-specific translations that fall through to system, then full locale, then base locale, then the default template strings. en_us_systemA_branchX => en_us_systemA => en_us => en =>